Make self fresh in capability classes

Author: noti0na1

compiler/src/dotty/tools/dotc/cc/Setup.scala

@@ -729,8 +729,11 @@ class Setup extends PreRecheck, SymTransformer, SetupAPI:
                   // is cls is known to be pure, nothing needs to be added to self type
                   selfInfo
                 else if cls.derivesFrom(defn.Caps_Capability) then
-                  CapturingType(cinfo.selfType, CaptureSet.csImpliedByCapability)
-                  // CapturingType(cinfo.selfType, CaptureSet.universal)
+                  // If cls is a capability class, we need to add a fresh capability to
+                  // ensure we cannot tread itself as pure.
+                  CapturingType(cinfo.selfType,
+                    CaptureSet.fresh(Origin.InDecl(cls)).readOnly
+                    ++ CaptureSet.Var(cls, level = ccState.currentLevel))
                 else if !cls.isEffectivelySealed && !cls.baseClassHasExplicitNonUniversalSelfType then
                   // assume {cap} for completely unconstrained self types of publicly extensible classes
                   CapturingType(cinfo.selfType, CaptureSet.universal)

tests/neg-custom-args/captures/i23223.scala

@@ -0,0 +1,12 @@
+import language.experimental.captureChecking
+import caps.*
+
+class A:
+  def a: A = this
+
+class B extends A, Capability // error
+
+def leak(b: B): A = b.a
+
+class C extends Capability:
+  def c: C^{} = this // error

tests/pos-custom-args/captures/i20237.scala

@@ -1,8 +1,12 @@
 import language.experimental.captureChecking
+import caps.*
 
 class Cap extends caps.Capability:
   def use[T](body: Cap ?=> T) = body(using this)
 
+class Cap2 extends caps.Capability:
+  def use[T](body: Cap2 => T) = body(this)
+
 class Box[T](body: Cap ?=> T):
   inline def open(using cap: Cap) = cap.use(body)