Fix recursive update with GET

Calling .get() recursively multiple times on the same object would break

Author: Anthony Ruhier

netboxapi/mapper.py

@@ -57,9 +57,14 @@ def get(self, *args, limit=50, **kwargs):
         new_mappers_props = self._iterate_over_get_query(route, kwargs)
         for nm_prop in new_mappers_props:
             try:
-                yield self._build_new_mapper_from(
-                    nm_prop, self._route + "{}/".format(nm_prop["id"])
-                )
+                if getattr(self, "id", None) is not None:
+                    new_mapper_route = route
+                else:
+                    new_mapper_route = self._route + "{}/".format(
+                        nm_prop["id"]
+                    )
+
+                yield self._build_new_mapper_from(nm_prop, new_mapper_route)
             except (KeyError, TypeError):
                 # Result objects have no id, cannot build a mapper from them,
                 # yield them as received

tests/test_mapper.py

@@ -67,6 +67,18 @@ def test_get_id(self, mapper):
         assert obj.name == "test"
         assert obj.id == 1
 
+    def test_get_update_obj(self, mapper):
+        url = self.get_mapper_url(mapper) + "1/"
+        expected_attr = {"id": 1, "name": "test"}
+        with requests_mock.Mocker() as m:
+            m.register_uri("get", url, json=expected_attr)
+            obj = next(mapper.get(1))
+            obj_clone = next(obj.get())
+            obj_clone = next(obj_clone.get())
+
+        assert obj.name == obj_clone.name
+        assert obj.id == obj_clone.id
+
     def test_get_query(self, mapper):
         url = self.get_mapper_url(mapper) + "?name=test"
         expected_attr = {