Skip to content

Commit 91e7e0a

Browse files
author
Anthony Ruhier
committed
Fix route set by mapper.get()
1 parent 9c7c11c commit 91e7e0a

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

netboxapi/mapper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def get(self, *args, **kwargs):
6060
try:
6161
for d in new_mappers_dict:
6262
yield self._build_new_mapper_from(
63-
d, route + "{}/".format(d["id"])
63+
d, self._route + "{}/".format(d["id"])
6464
)
6565
except KeyError:
6666
# Result objects have no id, cannot build a mapper from them,

tests/test_mapper.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,16 @@ def test_get_submodel(self, mapper):
5757
for key, val in expected_attr["results"][0].items():
5858
assert getattr(submodel_mapper, key) == val
5959

60+
def test_get_id(self, mapper):
61+
url = self.get_mapper_url(mapper) + "1/"
62+
expected_attr = {"id": 1, "name": "test"}
63+
with requests_mock.Mocker() as m:
64+
m.register_uri("get", url, json=expected_attr)
65+
obj = next(mapper.get(1))
66+
67+
assert obj.name == "test"
68+
assert obj.id == 1
69+
6070
def test_get_query(self, mapper):
6171
url = self.get_mapper_url(mapper) + "?name=test"
6272
expected_attr = {
@@ -416,7 +426,7 @@ def test_delete_from_child(self, mapper):
416426
obj_mapper = next(mapper.get(1))
417427

418428
with requests_mock.Mocker() as m:
419-
m.register_uri("delete", url + "1/")
429+
m.register_uri("delete", url)
420430
response = obj_mapper.delete()
421431

422432
assert response.status_code == 200

0 commit comments

Comments
 (0)