chore: remove computed from locality schemas

remyleone · remyleone · commit 03c59a6dbe85 · 2025-09-09T15:55:18.000+02:00
diff --git a/internal/locality/regional/schemas.go b/internal/locality/regional/schemas.go
@@ -31,7 +31,11 @@ func Schema() *schema.Schema {
 		Description:      "The region you want to attach the resource to",
 		Optional:         true,
 		ForceNew:         true,
-		Computed:         true,
 		ValidateDiagFunc: locality.ValidateStringInSliceWithWarning(allRegions(), "region"),
+		DiffSuppressFunc: suppressSDKNullAssignment,
 	}
 }
+
+func suppressSDKNullAssignment(k, old, new string, d *schema.ResourceData) bool {
+	return new == "" && old != ""
+}
diff --git a/internal/locality/zonal/schemas.go b/internal/locality/zonal/schemas.go
@@ -31,7 +31,11 @@ func Schema() *schema.Schema {
 		Description:      "The zone you want to attach the resource to",
 		Optional:         true,
 		ForceNew:         true,
-		Computed:         true,
 		ValidateDiagFunc: locality.ValidateStringInSliceWithWarning(AllZones(), "zone"),
+		DiffSuppressFunc: suppressSDKNullAssignment,
 	}
 }
+
+func suppressSDKNullAssignment(k, old, new string, d *schema.ResourceData) bool {
+	return new == "" && old != ""
+}

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,11 @@ func Schema() *schema.Schema {`
`31`	`31`	`Description: "The region you want to attach the resource to",`
`32`	`32`	`Optional: true,`
`33`	`33`	`ForceNew: true,`
`34`		`- Computed: true,`
`35`	`34`	`ValidateDiagFunc: locality.ValidateStringInSliceWithWarning(allRegions(), "region"),`
	`35`	`+ DiffSuppressFunc: suppressSDKNullAssignment,`
`36`	`36`	`}`
`37`	`37`	`}`
	`38`	`+`
	`39`	`+func suppressSDKNullAssignment(k, old, new string, d *schema.ResourceData) bool {`
	`40`	`+ return new == "" && old != ""`
	`41`	`+}`