fixup: callPostObject error cleanup

Author: Will Toozs

lib/api/apiUtils/apiCallers/callPostObject.js

@@ -56,8 +56,6 @@ async function parseFormData(request, response, requestContexts, log) {
 
         formDataParser.on('file', async (fieldname, file, filename, encoding, mimetype) => {
             if (fileEventData) {
-                const err = errors.InvalidArgument
-                    .customizeDescription('POST requires exactly one file upload per request.');
                 file.resume(); // Resume the stream to drain and discard the file
                 if (tempFilePath) {
                     fs.unlink(tempFilePath, unlinkErr => {
@@ -66,15 +64,15 @@ async function parseFormData(request, response, requestContexts, log) {
                         }
                     });
                 }
-                return reject(err);
+                return reject(errors.InvalidArgument
+                    .customizeDescription('POST requires exactly one file upload per request.'));
             }
 
             fileEventData = { fieldname, file, filename, encoding, mimetype };
             if (!('key' in request.formData)) {
-                const err = errors.InvalidArgument
+                return reject(errors.InvalidArgument
                     .customizeDescription('Bucket POST must contain a field named '
-                        + "'key'.  If it is specified, please check the order of the fields.");
-                return reject(err);
+                        + "'key'.  If it is specified, please check the order of the fields."));
             }
             // Replace `${filename}` with the actual filename
             request.formData.key = request.formData.key.replace('${filename}', filename);
@@ -111,9 +109,8 @@ async function parseFormData(request, response, requestContexts, log) {
 
         formDataParser.on('finish', () => {
             if (!fileEventData) {
-                const err = errors.InvalidArgument
-                    .customizeDescription('POST requires exactly one file upload per request.');
-                return reject(err);
+                return reject(errors.InvalidArgument
+                    .customizeDescription('POST requires exactly one file upload per request.'));
             }
             return formParserFinishedPromiseResolve();
         });
@@ -130,11 +127,12 @@ async function parseFormData(request, response, requestContexts, log) {
     });
 }
 
-function getFileStat(filePath) {
+function getFileStat(filePath, log) {
     return new Promise((resolve, reject) => {
         fs.stat(filePath, (err, stats) => {
             if (err) {
-                return reject(err);
+                log.trace('Error getting file size', { error: err });
+                return reject(errors.InternalError);
             }
             return resolve(stats);
         });
@@ -151,7 +149,7 @@ async function processPostForm(request, response, requestContexts, log, callback
         const { userInfo, authorizationResults, streamingV4Params } =
             await parseFormData(request, response, requestContexts, log);
 
-        const fileStat = await getFileStat(request.fileEventData.file);
+        const fileStat = await getFileStat(request.fileEventData.file, log);
         request.parsedContentLength = fileStat.size;
         request.fileEventData.file = fs.createReadStream(request.fileEventData.file);
         if (request.formData['content-type']) {