Skip to content

Factor out shell logic from tox.ini #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bsipocz opened this issue May 13, 2025 · 3 comments
Open

Factor out shell logic from tox.ini #36

bsipocz opened this issue May 13, 2025 · 3 comments
Assignees

Comments

@bsipocz
Copy link
Member

bsipocz commented May 13, 2025

And also add calling make html instead of sphinx-build

@danielballan
Copy link
Contributor

FWIW I am in favor of tox calling sphinx directly: I think task-runners calling other task-runners might obfuscate the action in way that is confusing for readers.

@bsipocz
Copy link
Member Author

bsipocz commented May 13, 2025

I very strongly feel that all the files in the repo should be called by a runner otherwise the chances that they bit rot is non-negligible. I don't particularly care how to achieve that, I don't feel bad about calling make html instead of calling the same sphinx line.

@danielballan
Copy link
Contributor

all the files in the repo should be called by a runner

Fully agree.

I don't feel bad about calling make html [from inside tox.ini]

OK, I don't feel strongly about this.

@bsipocz bsipocz self-assigned this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants