You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pack_bit_vector_into_field_element_vector everywhere uses fieldT::floor_size_in_bits(), but it seems like it should be using capacity/ceil_size_in_bits().
(This got changed from capacity in #103, however that was a non-breaking change, and actually just reflected what the old field API did)
The text was updated successfully, but these errors were encountered:
@ValarDragon,
I also thought this was an error and checked it.
However, div_ceil is called inside the function.
Therefore, The repacked_size seems to be calculated safely.
When "vector bit size" and "field bit size" are the same, and the "vector value" is greater than the "field size", I think ceil_size_in_bits() is not sufficient.
pack_bit_vector_into_field_element_vector everywhere uses
fieldT::floor_size_in_bits()
, but it seems like it should be usingcapacity/ceil_size_in_bits()
.(This got changed from capacity in #103, however that was a non-breaking change, and actually just reflected what the old field API did)
The text was updated successfully, but these errors were encountered: