*: Use [:blank:] instead of $'\t ' tricks where appropriate, fixes #19

Author: scop

bash_completion

@@ -260,7 +260,7 @@ __reassemble_comp_words_by_ref()
                 # Is word separator not preceded by whitespace in original line
                 # and are we not going to append to word 0 (the command
                 # itself), then append to current word.
-                [[ $line != [$' \t']* ]] && (( j >= 2 )) && ((j--))
+                [[ $line != [[:blank:]]* ]] && (( j >= 2 )) && ((j--))
                 # Append word separator to current or new word
                 ref="$2[$j]"
                 printf -v "$ref" %s "${!ref}${COMP_WORDS[i]}"
@@ -270,7 +270,7 @@ __reassemble_comp_words_by_ref()
                 line=${line#*"${COMP_WORDS[$i]}"}
                 # Start new word if word separator in original line is
                 # followed by whitespace.
-                [[ $line == [$' \t']* ]] && ((j++))
+                [[ $line == [[:blank:]]* ]] && ((j++))
                 # Indicate next word if available, else end *both* while and
                 # for loop
                 (( $i < ${#COMP_WORDS[@]} - 1)) && ((i++)) || break 2
@@ -781,7 +781,7 @@ _parse_help()
       esac } \
     | while read -r line; do
 
-        [[ $line == *([ $'\t'])-* ]] || continue
+        [[ $line == *([[:blank:]])-* ]] || continue
         # transform "-f FOO, --foo=FOO" to "-f , --foo=FOO" etc
         while [[ $line =~ \
             ((^|[^-])-[A-Za-z0-9?][[:space:]]+)\[?[A-Z0-9]+\]? ]]; do
@@ -1567,7 +1567,7 @@ _known_hosts_real()
 
     # append any available aliases from config files
     if [[ ${#config[@]} -gt 0 && -n "$aliases" ]]; then
-        local hosts=$( command sed -ne 's/^['"$'\t '"']*[Hh][Oo][Ss][Tt]['"$'\t '"']\{1,\}\([^#*?%]*\)\(#.*\)\{0,1\}$/\1/p' "${config[@]}" )
+        local hosts=$( command sed -ne 's/^[[:blank:]]*[Hh][Oo][Ss][Tt][[:blank:]]\{1,\}\([^#*?%]*\)\(#.*\)\{0,1\}$/\1/p' "${config[@]}" )
         COMPREPLY+=( $( compgen -P "$prefix$user" \
             -S "$suffix" -W "$hosts" -- "$cur" ) )
     fi

completions/dict

@@ -3,7 +3,7 @@
 _dictdata()
 {
     dict $host $port $1 2>/dev/null | command sed -ne \
-        's/^['$'\t '']\{1,\}\([^ '$'\t'']*\).*$/\1/p'
+        's/^[[:blank:]]\{1,\}\([^[:blank:]]*\).*$/\1/p'
 }
 
 _dict()

completions/kldunload

@@ -7,8 +7,8 @@ _kldunload()
     local cur prev words cword
     _init_completion || return
 
-    COMPREPLY=( $( kldstat | \
-        command sed -ne "s/^.*[ $'\t']\{1,\}\($cur[a-z_]\{1,\}\).ko$/\1/p" ) )
+    COMPREPLY=( $( kldstat | command sed -ne \
+        "s/^.*[[:blank:]]\{1,\}\($cur[a-z_]\{1,\}\).ko$/\1/p" ) )
 } &&
 complete -F _kldunload kldunload
 

completions/mount

@@ -42,8 +42,8 @@ _mount()
         if [[ -n $host ]]; then
             COMPREPLY=( $( compgen -P "//$host" -W \
                 "$( smbclient -d 0 -NL $host 2>/dev/null |
-                command sed -ne '/^['"$'\t '"']*Sharename/,/^$/p' |
-                command sed -ne '3,$s|^[^A-Za-z]*\([^'"$'\t '"']*\).*$|/\1|p' )" \
+                command sed -ne '/^[[:blank:]]*Sharename/,/^$/p' |
+                command sed -ne '3,$s|^[^A-Za-z]*\([^[:blank:]]*\).*$|/\1|p' )" \
                     -- "${cur#//$host}" ) )
         fi
     elif [[ -r /etc/vfstab ]]; then

completions/mount.linux

@@ -232,8 +232,8 @@ _mount()
         if [[ -n $host ]]; then
             COMPREPLY=( $( compgen -P "//$host" -W \
                 "$( smbclient -d 0 -NL $host 2>/dev/null |
-                command sed -ne '/^['"$'\t '"']*Sharename/,/^$/p' |
-                command sed -ne '3,$s|^[^A-Za-z]*\([^'"$'\t '"']*\).*$|/\1|p' )" \
+                command sed -ne '/^[[:blank:]]*Sharename/,/^$/p' |
+                command sed -ne '3,$s|^[^A-Za-z]*\([^[:blank:]]*\).*$|/\1|p' )" \
                     -- "${cur#//$host}" ) )
         fi
     fi

completions/valgrind

@@ -70,7 +70,7 @@ _valgrind()
         # generic cases parsed from --help output
         --+([-A-Za-z0-9_]))
             local value=$( $1 --help-debug $tool 2>/dev/null | \
-                command sed -ne "s|^[$' \t']*$prev=\([^$' \t']\{1,\}\).*|\1|p" )
+                command sed -ne "s|^[[:blank:]]*$prev=\([^[:blank:]]\{1,\}\).*|\1|p" )
             case $value in
                 \<file*\>)
                     _filedir