-
Fork the project and clone your fork.
-
Create a local feature branch:
$ git checkout -b <branch>
-
If adding a function
R.foo
, define it in src/foo.js and include unit tests in test/foo.js. If adding an internal function_foo
, define it in _src/internal/foo.js. -
Make one or more atomic commits. Each commit should have a descriptive commit message, wrapped at 72 characters. Do not commit changes to dist/ramda.js.
-
Run
make test lint
, (orgrunt test
) and address any errors. Preferably, fix commits in place usinggit rebase
orgit commit --amend
to make the changes easier to review and to keep the history tidy. -
Push to your fork:
$ git push origin <branch>
-
Open a pull request.
- Do not use
Array.prototype.push
. Usexs[idx] = x
orxs[xs.length] = x
rather thanxs.push(x)
. See #890 for links to related pull requests.