Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of single-letter currencies #3

Open
kmike opened this issue Apr 17, 2019 · 0 comments
Open

Improve handling of single-letter currencies #3

kmike opened this issue Apr 17, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@kmike
Copy link
Member

kmike commented Apr 17, 2019

Some of the single-letter currencies are not picked up:

In [7]: Price.fromstring('R273.00')
Out[7]: Price(amount=Decimal('273.00'), currency=None)

In [9]: Price.fromstring('61.858 L')  # Romanian New Leu
Out[9]: Price(amount=Decimal('61858'), currency=None)

We should support them. The main issue is that they're ambiguous; we should be careful not to pick e.g. L or R letter from the extra text appearing in price string passed.

@kmike kmike changed the title Handle single-letter currencies Improve handling of single-letter currencies Apr 17, 2019
@kmike kmike added the help wanted Extra attention is needed label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant