New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slackclient with websocket #181

Open

alexsilva opened this issue Nov 13, 2018 · 0 comments

alexsilva commented Nov 13, 2018

The connection with websocket has several problems and many of them are hidden.

The ping method does not validate the returned data.:
https://github.com/lins05/slackbot/blob/develop/slackbot/slackclient.py#L89

It gave me some work but I was able to do the validation:
https://github.com/alexsilva/django-slack-sync/blob/master/slack_sync/slackclient.py#L104

I had other problems reading websock data but using select I managed to solve it:
https://github.com/alexsilva/django-slack-sync/blob/master/slack_sync/slackclient.py#L74

I leave the links as references as possible solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment