Skip to content

Commit 167fb2b

Browse files
devversionatscott
authored andcommitted
ci: re-enable components-repo-unit-tests job after APF v13 adjustments (angular#43798)
The APF v13 changes have landed in the `angular/components` repository so that the CI check can be re-enabled. PR Close angular#43798
1 parent a82c55f commit 167fb2b

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

.circleci/config.yml

+4-6
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ var_4_win: &cache_key_win_fallback v5-angular-win-node-14-{{ checksum "month.txt
3636

3737
# Cache key for the `components-repo-unit-tests` job. **Note** when updating the SHA in the
3838
# cache keys also update the SHA for the "COMPONENTS_REPO_COMMIT" environment variable.
39-
var_5: &components_repo_unit_tests_cache_key v1-angular-components-{{ checksum "month.txt" }}-db18b4093f23ae5c0ef76f6a9699c670ee5d55f7
39+
var_5: &components_repo_unit_tests_cache_key v1-angular-components-{{ checksum "month.txt" }}-83da73fb621720fbe801d3a503d50fd82b3da0c8
4040
var_6: &components_repo_unit_tests_cache_key_fallback v1-angular-components-{{ checksum "month.txt" }}
4141

4242
# Workspace initially persisted by the `setup` job, and then enhanced by `build-npm-packages`.
@@ -878,11 +878,9 @@ workflows:
878878
# since the publishing script expects the legacy outputs layout.
879879
- build-npm-packages
880880
- legacy-unit-tests-saucelabs
881-
# TODO(devversion): re-enable once the Angular components repo has been updated to deal
882-
# with partial compilation APF v13 package output (i.e. with the linker processing).
883-
#- components-repo-unit-tests:
884-
# requires:
885-
# - build-npm-packages
881+
- components-repo-unit-tests:
882+
requires:
883+
- build-npm-packages
886884
- test_zonejs:
887885
requires:
888886
- setup

.circleci/env.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ setPublicVar COMPONENTS_REPO_TMP_DIR "/tmp/angular-components-repo"
7474
setPublicVar COMPONENTS_REPO_URL "https://github.com/angular/components.git"
7575
setPublicVar COMPONENTS_REPO_BRANCH "master"
7676
# **NOTE**: When updating the commit SHA, also update the cache key in the CircleCI `config.yml`.
77-
setPublicVar COMPONENTS_REPO_COMMIT "db18b4093f23ae5c0ef76f6a9699c670ee5d55f7"
77+
setPublicVar COMPONENTS_REPO_COMMIT "83da73fb621720fbe801d3a503d50fd82b3da0c8"
7878

7979

8080
####################################################################################################

scripts/ci/run_angular_components_unit_tests.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ cd ${COMPONENTS_REPO_TMP_DIR}
1515

1616
# Now actually run the tests. The dev-app and all its subpackages are excluded as they fail
1717
# to compile due to limitations in Ivy's type checker (see FW-1352 and FW-1433)
18-
bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local --config=ivy -- src/... -src/dev-app/...
18+
bazel test --build_tag_filters=-docs-package,-e2e,-browser:firefox-local --test_tag_filters=-e2e,-browser:firefox-local -- src/... -src/dev-app/...

0 commit comments

Comments
 (0)