Skip to content

Commit e56472d

Browse files
devversionthePunderWoman
authored andcommitted
ci: fix stamping for builds performed in CI (angular#45147)
Fixes the stamping for snapshot builds and the artifact deployment job. Currently the stamped versions will have the `.with-local-changes` version suffix given that we add a file to the Git repo that is just needed for the CircleCI cache key computation. PR Close angular#45147
1 parent e01820c commit e56472d

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

.circleci/config.yml

+2
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ commands:
188188
steps:
189189
- run:
190190
name: Save month to file
191+
# Note: Make sure this file is excluded in the `.gitignore` as otherwise the
192+
# snapshot stamping would have the `-with-local-changes` suffix.
191193
command: date +%Y-%m > month.txt
192194

193195
# Normally this would be an individual job instead of a command.

.circleci/env.sh

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
# Variables
44
readonly projectDir=$(realpath "$(dirname ${BASH_SOURCE[0]})/..")
55
readonly envHelpersPath="$projectDir/.circleci/env-helpers.inc.sh";
6-
readonly bashEnvCachePath="$projectDir/.circleci/bash_env_cache";
76

87
# Load helpers and make them available everywhere (through `$BASH_ENV`).
98
source $envHelpersPath;

.gitignore

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
*.log
77
node_modules
88

9+
# CircleCI temporary file for cache key computation.
10+
# See `save_month_to_file` in `.circleci/config.yml`.
11+
month.txt
12+
913
# Include when developing application packages.
1014
pubspec.lock
1115
.c9

0 commit comments

Comments
 (0)