Skip to content

Commit f6859e8

Browse files
devversionthePunderWoman
authored andcommitted
build: replace size-tracking test with rule from shared dev-infra (angular#46802)
The JS size-tracking logic has been moved into the dev-infra repository and the rule has been updated to work better with Bazel labels. The Starlark target is updated accordingly in this commit. PR Close angular#46802
1 parent 10495a8 commit f6859e8

12 files changed

+313
-1052
lines changed

.pullapprove.yml

-1
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,6 @@ groups:
11181118
'tools/legacy-saucelabs/**/{*,.*}',
11191119
'tools/rxjs/**/{*,.*}',
11201120
'tools/saucelabs/**/{*,.*}',
1121-
'tools/size-tracking/**/{*,.*}',
11221121
'tools/symbol-extractor/**/{*,.*}',
11231122
'tools/testing/**/{*,.*}',
11241123
'tools/tslint/**/{*,.*}',

packages/core/test/bundling/core_all/BUILD.bazel

+5-9
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//tools:defaults.bzl", "app_bundle", "ts_library")
2-
load("//tools/size-tracking:index.bzl", "js_size_tracking_test")
2+
load("@npm//@angular/dev-infra-private/bazel/map-size-tracking:index.bzl", "js_mapping_size_test")
33

44
package(default_visibility = ["//visibility:public"])
55

@@ -22,17 +22,13 @@ app_bundle(
2222
],
2323
)
2424

25-
js_size_tracking_test(
25+
js_mapping_size_test(
2626
name = "size_test",
27-
src = "angular/packages/core/test/bundling/core_all/bundle.min.js",
28-
data = [
29-
"bundle.golden_size_map.json",
30-
":bundle",
31-
],
32-
golden_file = "angular/packages/core/test/bundling/core_all/bundle.golden_size_map.json",
27+
src = ":bundle.min.js",
28+
golden_file = ":bundle.golden_size_map.json",
3329
max_byte_diff = 250,
3430
max_percentage_diff = 15,
35-
source_map = "angular/packages/core/test/bundling/core_all/bundle.min.js.map",
31+
source_map = ":bundle.min.js.map",
3632
tags = [
3733
"manual",
3834
],

0 commit comments

Comments
 (0)