This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Scroll dev 1011#34
Closed
zhenfeizhang wants to merge 20 commits into
Closed
Conversation
…verify_circuit now
…iy with zkevm bench
tests for single proof verify in chip for lookup, mul_add pass
…o2_proofs, so they can be uniformly patched at root level
constants during keygen_vk
now keygen_vk actually works for tests/mul_add_{single, aggregate}
Made changes because vkey write doesn't currently work.
now passes zkevm_bench with MockProver this resolves an issues where the final_pair computation in verify_circuit was incorrect because halo2_ecc did not detect (0,0) elliptic curve points, which should be treated as identity in the group
circuit and 1 state circuit * switched zkevm and halo2 repos to scroll-dev to get state circuit to prove correctly
Contributor
Author
|
replaced with #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.