Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on github actions are not passing #159

Open
ajmejia opened this issue Oct 22, 2024 · 0 comments
Open

Tests on github actions are not passing #159

ajmejia opened this issue Oct 22, 2024 · 0 comments

Comments

@ajmejia
Copy link
Contributor

ajmejia commented Oct 22, 2024

Here's the log output:

fatal: not a git repository (or any of the parent directories): .git [WARNING]: error 128 while getting commit hash: b'', setting hash to None ImportError while loading conftest '/home/runner/work/lvmdrp/lvmdrp/tests/conftest.py'. /home/runner/work/lvmdrp/lvmdrp/tests/conftest.py:17: in <module> from lvmdrp.core.image import _parse_ccd_section core/image.py:28: in <module> from cextern.fast_median.fast_median import fast_median_filter_2d E ModuleNotFoundError: No module named 'cextern.fast_median.fast_median' Error: Process completed with exit code 4.

The error may originate in a failed compilation of the external libraries for fast_median. We need properly implement this external C++ library as an extension as documented here:

https://setuptools.pypa.io/en/latest/userguide/ext_modules.html

Custom compiler and options are also discussed, in the framework of setuptools, here:

https://stackoverflow.com/questions/47872981/python-extension-using-different-compiler-flags-for-a-c-parts-and-c-parts

and other related threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant