Razor is now bundled with roslyn which breaks current roslyn.nvim

[davidkudera]

Description

Roslyn version: 5.8.0-1.26262.10+036e7a58b9d4348a62b6854544274551ae17ae8c

Error:

Unrecognized command or argument      
  '--razorSourceGenerator=/home/david/.local/share/nvim/mason/packages/roslyn/libexec/.razorExtension/Microsoft.CodeAnalysis.Razor.Compiler.dll'
Unrecognized command or argument       
  '--razorDesignTimePath=/home/david/.local/share/nvim/mason/packages/roslyn/libexec/.razorExtension/Targets/Microsoft.NET.Sdk.Razor.DesignTime.targets'

Related (probably) PR from dotnet/roslyn: dotnet/roslyn#83575

Fix:

require("roslyn").setup({
  extensions = {
    razor = { enabled = false },
  },
})

Neovim version

v0.12.2

Operating system and version

Arch Linux

Expected behavior

New version of roslyn should work.

Actual behavior

It doesn't work

Minimal config

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
    spec = {
        {

            "mason-org/mason.nvim",
            opts = {
                registries = {
                    "github:mason-org/mason-registry",
                    "github:crashdummyy/mason-registry",
                },
            },
        },
        {
            "seblyng/roslyn.nvim",
            init = function()
                vim.filetype.add({
                    extension = {
                        razor = "razor",
                        cshtml = "razor",
                    },
                })
            end,
        },
    },
})

Roslyn checkhealth

==============================================================================
roslyn:                                                                   1 ⚠️

roslyn.nvim: Requirements ~
- ✅ OK Neovim >= 0.12
- ✅ OK dotnet SDK >= 10 (found 10.0.104)

roslyn.nvim: Roslyn Language Server ~
- ✅ OK /home/david/.local/share/nvim/mason/bin/roslyn: found

roslyn.nvim: Roslyn extensions: ~

'razor' ~
- ✅ OK Enabled
- ✅ OK Resolved path: '/home/david/.local/share/nvim/mason/packages/roslyn/libexec/.razorExtension/Microsoft.VisualStudioCode.RazorExtension.dll' (file exists)
- ✅ OK Resolved args:
  --razorSourceGenerator=/home/david/.local/share/nvim/mason/packages/roslyn/libexec/.razorExtension/Microsoft.CodeAnalysis.Razor.Compiler.dll
  --razorDesignTimePath=/home/david/.local/share/nvim/mason/packages/roslyn/libexec/.razorExtension/Targets/Microsoft.NET.Sdk.Razor.DesignTime.targets
- ✅ OK vscode-html-language-server: found
- ✅ OK html-lsp client: configured

roslyn.nvim: File Watching Configuration ~
- ⚠️ WARNING Roslyn is not running. Cannot determine file watching configuration.

roslyn.nvim: Solution Detection ~
- No solution selected

[Crashdummyy]

You're right about that, thanks for mentioning it this early.
They're (microsoft) are on fire right now and produced 3 releases today.
The latest one for both stable and unstable will not ship the .razorExtensions directory anymore.

I am currently glueing everything together.
For now you can just update roslyn-unstable again.
You can ignore the "missing extension" warning there for now.
It will still work as it did before the change

[davidkudera]

@Crashdummyy Thanks. I actually just disabled razor in roslyn.nvim, and that was enough. With that, everything works as expected. Roslyn enables built-in razor support internally, and roslyn.nvim will not try to enable it too in the old way (my guess).

require("roslyn").setup({
  extensions = {
    razor = { enabled = false },
  },
})

[Crashdummyy]

@Crashdummyy Thanks. I actually just disabled razor in roslyn.nvim, and that was enough. With that, everything works as expected. Roslyn enables built-in razor support internally, and roslyn.nvim will not try to enable it too in the old way (my guess).

require("roslyn").setup({
extensions = {
razor = { enabled = false },
},
})

Thats what I'm currently implementing yes.
It's basically the same logic with the new release.
The moment .razorExtensions does not exist ( we dont ship it anymore ) you just get a warning and the razor plugin is disabled.
We won't need that magic in the future now

[seblyng]

Closed by #361