Skip to content

Commit 3b3c85d

Browse files
committed
#4651 Try distinguishing freezes from crashes
1 parent 8eb0156 commit 3b3c85d

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

indra/newview/llappviewer.cpp

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3945,8 +3945,15 @@ void LLAppViewer::processMarkerFiles()
39453945
else if (marker_is_same_version)
39463946
{
39473947
// the file existed, is ours, and matched our version, so we can report on what it says
3948-
LL_INFOS("MarkerFile") << "Exec marker '"<< mMarkerFileName << "' found; last exec crashed" << LL_ENDL;
3948+
LL_INFOS("MarkerFile") << "Exec marker '"<< mMarkerFileName << "' found; last exec crashed or froze" << LL_ENDL;
3949+
#if LL_WINDOWS && LL_BUGSPLAT
3950+
// bugsplat will set correct state in bugsplatSendLog
3951+
// Might be more accurate to rename this one into 'unknown'
3952+
gLastExecEvent = LAST_EXEC_FROZE;
3953+
#else
39493954
gLastExecEvent = LAST_EXEC_OTHER_CRASH;
3955+
#endif // LL_WINDOWS
3956+
39503957
}
39513958
else
39523959
{

indra/newview/llappviewerwin32.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,18 @@ namespace
172172
<< '/' << loc.mV[1]
173173
<< '/' << loc.mV[2])));
174174
}
175+
176+
if (!LLAppViewer::instance()->isSecondInstance())
177+
{
178+
std::string error_marker_file = gDirUtilp->getExpandedFilename(LL_PATH_LOGS, ERROR_MARKER_FILE_NAME);
179+
if (!LLAPRFile::isExist(error_marker_file, NULL, LL_APR_RB))
180+
{
181+
// If marker doesn't exist, create a marker with 'other' code for next launch
182+
// otherwise don't override existing file
183+
// Any unmarked crashes will be considered as freezes
184+
LLAppViewer::instance()->createErrorMarker(LAST_EXEC_OTHER_CRASH);
185+
}
186+
}
175187
} // MDSCB_EXCEPTIONCODE
176188

177189
return false;

0 commit comments

Comments
 (0)