#4893 Tighten LLView child cache

- store cache keys as std::string to avoid dangling references
- refresh parent entry on rename and skip unnamed views

Author: marchcat

indra/llui/llview.cpp

@@ -253,6 +253,28 @@ const std::string& LLView::getName() const
     return mName.empty() ? no_name : mName;
 }
 
+void LLView::setName(const std::string& name)
+{
+    if (name == mName)
+    {
+        return;
+    }
+
+    LLView* parent = mParentView;
+
+    if (parent && !mName.empty())
+    {
+        parent->mChildNameCache.erase(mName);
+    }
+
+    mName = name;
+
+    if (parent && !mName.empty())
+    {
+        parent->mChildNameCache[mName] = this;
+    }
+}
+
 void LLView::sendChildToFront(LLView* child)
 {
 //  llassert_always(sDepth == 0); // Avoid re-ordering while drawing; it can cause subtle iterator bugs
@@ -306,7 +328,7 @@ bool LLView::addChild(LLView* child, S32 tab_group)
     mChildList.push_front(child);
 
     // Add to name cache for fast lookup
-    if (!child->getName().empty())
+    if (child->hasName())
     {
         mChildNameCache[child->getName()] = child;
     }
@@ -352,7 +374,7 @@ void LLView::removeChild(LLView* child)
         mChildList.remove( child );
 
         // Remove from name cache
-        if (!child->getName().empty())
+        if (child->hasName())
         {
             mChildNameCache.erase(child->getName());
         }
@@ -1663,10 +1685,14 @@ LLView* LLView::findChildView(std::string_view name, bool recurse) const
     LL_PROFILE_ZONE_SCOPED_CATEGORY_UI;
 
     // Check cache first for direct children - O(1) lookup instead of O(n)
-    auto cache_it = mChildNameCache.find(name);
-    if (cache_it != mChildNameCache.end())
+    if (!mChildNameCache.empty())
     {
-        return cache_it->second;
+        std::string lookup_key(name);
+        auto cache_it = mChildNameCache.find(lookup_key);
+        if (cache_it != mChildNameCache.end())
+        {
+            return cache_it->second;
+        }
     }
 
     // Look for direct children *first*
@@ -1676,7 +1702,10 @@ LLView* LLView::findChildView(std::string_view name, bool recurse) const
         if (childp->getName() == name)
         {
             // Cache the result for next lookup
-            mChildNameCache[name] = childp;
+            if (childp->hasName())
+            {
+                mChildNameCache[childp->getName()] = childp;
+            }
             return childp;
         }
     }

indra/llui/llview.h

@@ -49,6 +49,7 @@
 #include "llfocusmgr.h"
 
 #include <list>
+#include <unordered_map>
 #include <boost/function.hpp>
 #include <boost/noncopyable.hpp>
 
@@ -237,7 +238,8 @@ class LLView
     void        setFollowsAll()                 { mReshapeFlags |= FOLLOWS_ALL; }
 
     void        setSoundFlags(U8 flags)         { mSoundFlags = flags; }
-    void        setName(std::string name)           { mName = name; }
+    void        setName(const std::string& name);
+    bool        hasName() const                     { return !mName.empty(); }
     void        setUseBoundingRect( bool use_bounding_rect );
     bool        getUseBoundingRect() const;
 
@@ -590,7 +592,7 @@ class LLView
     child_list_t mChildList;
 
     // Cache for fast child lookup by name - O(1) instead of O(n)
-    mutable std::unordered_map<std::string_view, LLView*> mChildNameCache;
+    mutable std::unordered_map<std::string, LLView*> mChildNameCache;
 
     // location in pixels, relative to surrounding structure, bottom,left=0,0
     bool        mVisible;