#3395 Make LLProfile error more detailed

akleshchev · akleshchev · commit 8a0863f1dd9f · 2025-01-16T19:01:19.000+02:00
diff --git a/indra/llmath/llvolume.cpp b/indra/llmath/llvolume.cpp
@@ -766,7 +766,8 @@ bool LLProfile::generate(const LLProfileParams& params, bool path_open,F32 detai
 
     S32 face_num = 0;
 
-    switch (params.getCurveType() & LL_PCODE_PROFILE_MASK)
+    U8 curve_type = params.getCurveType() & LL_PCODE_PROFILE_MASK;
+    switch (curve_type)
     {
     case LL_PCODE_PROFILE_SQUARE:
         {
@@ -981,7 +982,9 @@ bool LLProfile::generate(const LLProfileParams& params, bool path_open,F32 detai
         }
         break;
     default:
-        LL_ERRS() << "Unknown profile: getCurveType()=" << params.getCurveType() << LL_ENDL;
+        LL_ERRS() << "Unknown profile: getCurveType()=" << (U32)params.getCurveType()
+                  << " with mask: " << (U32)curve_type
+                  << " params: " << params << LL_ENDL;
         break;
     };
 

Original file line number	Diff line number	Diff line change
`@@ -766,7 +766,8 @@ bool LLProfile::generate(const LLProfileParams& params, bool path_open,F32 detai`
`766`	`766`
`767`	`767`	`S32 face_num = 0;`
`768`	`768`
`769`		`- switch (params.getCurveType() & LL_PCODE_PROFILE_MASK)`
	`769`	`+ U8 curve_type = params.getCurveType() & LL_PCODE_PROFILE_MASK;`
	`770`	`+ switch (curve_type)`
`770`	`771`	`{`
`771`	`772`	`case LL_PCODE_PROFILE_SQUARE:`
`772`	`773`	`{`
`@@ -981,7 +982,9 @@ bool LLProfile::generate(const LLProfileParams& params, bool path_open,F32 detai`
`981`	`982`	`}`
`982`	`983`	`break;`
`983`	`984`	`default:`
`984`		`- LL_ERRS() << "Unknown profile: getCurveType()=" << params.getCurveType() << LL_ENDL;`
	`985`	`+ LL_ERRS() << "Unknown profile: getCurveType()=" << (U32)params.getCurveType()`
	`986`	`+ << " with mask: " << (U32)curve_type`
	`987`	`+ << " params: " << params << LL_ENDL;`
`985`	`988`	`break;`
`986`	`989`	`};`
`987`	`990`