Skip to content

Commit f26e6fd

Browse files
committed
Slightly reword rebasing on open PR paragraph
Emphasize on avoiding rebasing on open PRs, to make reviews easier, but allowing rebasing to fix conflicts.
1 parent c350621 commit f26e6fd

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

git-history.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,12 @@ even need to worry about this while coding. You can use `git add` in
4747
commits from a huge diff. Or use `git rebase` in `interactive` mode to rewrite
4848
the history of your *feature* branch to your hearts content.
4949

50-
__Resolve conflicts in an open *pull request*__ Once you have submitted a *pull
51-
request* and you are receiving reviews and comments, you should avoid rebasing,
52-
as it makes it harder to follow your changes on GitHub. However, if GitHub
53-
notifies you about conflicts, you should rebase and fix the conflicts. Ideally,
54-
you would do that after you addressed all review comments.
50+
__Rebasing in an open *pull request*__ Once you have submitted a *pull request*
51+
and you are receiving review comments, please avoid rebasing, as it makes it
52+
harder for reviewers to follow any changes that they requested. However, if
53+
GitHub notifies you about conflicts, you should rebase as described above,
54+
while fixing those conflicts. Ideally, you do that after addressing all review
55+
comments and having received another round of review.
5556

5657
#### Further reading
5758
Consider reading the resources listed below, especially if some of above

0 commit comments

Comments
 (0)