Skip to content

Fix TEX_SPECIAL assignment for liquids #12

@SirYodaJedi

Description

@SirYodaJedi

When Valve changed the character that defines liquids from * to !, they left the check for assigning the TEX_SPECIAL flag as asterisk, resulting in liquids always getting 240tx subdivision and lightmaps, unlike Quake.

if (bt->name[0] == '*'

This is a bit wasteful in vanilla renderers, since they don't support lightmapped water, so the check should be changed to set the flag for ! textures as well, unless you pass a -litwater param to CSG (for use with custom renderers). I suppose * textures should still receive this flag, for consistency with vanilla behavior, but I'm not sure if that's too important (idk what happens if a non-liquid gets this flag).

(Also, the length defined for env_sky's strncasecmp should be 7, not 5.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions