Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️ Build "revise term" alert box #141

Open
tatianamac opened this issue May 17, 2020 · 5 comments
Open

🗃️ Build "revise term" alert box #141

tatianamac opened this issue May 17, 2020 · 5 comments

Comments

@tatianamac
Copy link
Collaborator

tatianamac commented May 17, 2020

Overview

Build a component that follows each definition that encourages readers to submit revisions if needed.

Recommendation would be to build a separate .njk block that can be called by the definition template.

Design

Threw together a rough wireframe in Figma. It's not in the correct fonts but should give you an idea of the general structure.

Reach out with any questions!

@tatianamac
Copy link
Collaborator Author

@jlealess Here is an issue for you!

@tatianamac
Copy link
Collaborator Author

@jlealess Let me know if you have questions around this and/or are still able to contribute! I've opened up Self-Defined Saturdays on our Slack channel so folks have resources to help.

@ovlb
Copy link
Collaborator

ovlb commented May 23, 2020

@tatianamac It might be nice to have a «Edit this page on GitHub» link inside of the box. I think that’s a good short cut, especially if folks only want to fix a typo or something.

@tatianamac
Copy link
Collaborator Author

tatianamac commented May 23, 2020

@ovlb Agreed!

@jlealess
Copy link
Contributor

@tatianamac Yes, I'm definitely still around and looking to contribute! I started working on this last weekend and am hoping to finish up this weekend; a shortage of good 11ty guides has slowed me down but I'll have something to review soon and will add the link to edit on GitHub in the box.

@tatianamac tatianamac linked a pull request May 27, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants