Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Add Emoji parsing #33

Open
ovlb opened this issue Nov 22, 2019 · 2 comments
Open

Markdown: Add Emoji parsing #33

ovlb opened this issue Nov 22, 2019 · 2 comments
Labels
help wanted Good for external contributors Status · Needs Submitter Info Requires more information from submitter before proceeding Type · Accessibility Accessibility bugs and enhancements Type · Frontend Frontend work

Comments

@ovlb
Copy link
Collaborator

ovlb commented Nov 22, 2019

The standard markdown-it parser that ships with Eleventy does not parse emojis, which can lead to accessibility issues.

The ideal outcome has been described by Léonie Watson in her article Accessible emoji.

There is an existing plugin for markdown-it which has no accessible output by default but allows you to change it. Judging by the discussion in markdown-it/markdown-it-emoji#33 we also need to provide an own emoji library. 🤷‍♀️

@tatianamac tatianamac added the help wanted Good for external contributors label Feb 15, 2020
@mxmason
Copy link
Contributor

mxmason commented Apr 2, 2020

@ovlb, where do you see issues with the emoji that markdown-it produces? In my (admittedly shallow) sweep of the site with VoiceOver iOS, i was able to hear all the emojis I encountered.

Maybe I was encountering emoji which weren’t parsed by markdown-it?

@ovlb
Copy link
Collaborator Author

ovlb commented Apr 2, 2020

@dengeist markdown-it does not parse emoji whatsoever. It just put them out as raw text. It’s working fine with recent versions of VoiceOver. I still need to test it with NVDA. Unfortunately don’t have JAWS at my disposal.

Leonie described a pattern in the linked article in the OP. But this the article is several years old by now, so testing is in order.

One thing we might keep in mind is Adrian Roselli’s addendum to the article linked above
https://adrianroselli.com/2016/12/accessible-emoji-tweaked.html
He proposed a pattern in which the emoji reveals its name on tab or hover. Which can be useful for not emoji-affine users too.

@ovlb ovlb added Status · Needs Submitter Info Requires more information from submitter before proceeding Type · Accessibility Accessibility bugs and enhancements Type · Frontend Frontend work labels Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good for external contributors Status · Needs Submitter Info Requires more information from submitter before proceeding Type · Accessibility Accessibility bugs and enhancements Type · Frontend Frontend work
Projects
None yet
Development

No branches or pull requests

3 participants