Skip to content

Add an option to not mark maintenance releases as latest #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
viceice opened this issue Apr 22, 2024 · 6 comments · May be fixed by #884
Open

Add an option to not mark maintenance releases as latest #817

viceice opened this issue Apr 22, 2024 · 6 comments · May be fixed by #884

Comments

@viceice
Copy link

viceice commented Apr 22, 2024

I would like to have an option to not mark maintenance releases as latest on github.
Currently our main branch is on v4 and we've maintenance releases on v2.
Everytime a v2 get's released, it's marked as latest by default.
So an option to override would be very useful.
@viceice viceice changed the title Add an option to not mark maintenance releases as latest Add an option to not mark maintenance releases as latest Apr 22, 2024
@gr2m
Copy link
Member

gr2m commented Apr 25, 2024 •
edited by hearts bot
Loading

Hmm sounds like a bug to me in the first place. We probably just didn't get around to address this, or the APIs didn't exist at the time.

@travi
Copy link
Member

travi commented Apr 25, 2024 •
edited by hearts bot
Loading

agreed. i cant think of a reason why a maintenance release should ever be marked as latest

@michaelchambaud-eaton
Copy link

michaelchambaud-eaton commented Jul 24, 2024 •
edited by hearts bot
Loading

I have the same issue.

There is a make_latest: string (defaults: true) in GH API -> https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

I'm thinking it should be added here:

github/lib/publish.js

Line 54 in c70cfbf

prerelease: isPrerelease(branch),

@travi
Copy link
Member

travi commented Jul 24, 2024 •
edited by hearts bot
Loading

We do want to fix this. If you've investigated far enough to see a solution, please feel free to send a PR to keep this moving forward

@mchambaud mchambaud linked a pull request Jul 25, 2024 that will close this issue
Open
@robfraz
Copy link

robfraz commented Nov 13, 2024

Hello - is there any news on this issue? It looks like the linked PR has stalled...? 😢

Is there any kind of workaround anyone can recommend?

@viceice
Copy link
Author

viceice commented Mar 1, 2025 •
edited by hearts bot
Loading

simply setting make_latest=legacy will probably fix it too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

integrated make_latest property of gh api publish mchambaud/semantic-release-github
5 participants
@gr2m @travi @robfraz @viceice @michaelchambaud-eaton