Skip to content

release skip-ed commits still get into release notes #531

@amariq

Description

@amariq

The documentation says that a commit can be excluded from the analysis by adding [skip release] here:

https://semantic-release.gitbook.io/semantic-release/support/faq#can-i-exclude-commits-from-the-analysis

And yet, those commits end up within the changelog file generated by the changelog plugin.
But looking closely, it is the release-notes-generator that provides the list of changes to be used.

So, I checked the release-notes-generator's code and found that it doesn't use the skip release filtration logic:

https://github.com/semantic-release/release-notes-generator/blame/master/index.js#L48

which is present in the core:

https://github.com/semantic-release/semantic-release/blame/master/lib/definitions/plugins.js#L22

I see that this was added pretty long ago (3 years ago), but nothing seems to be done about it.

So, is it intentional?
Or is it just some barely used feature that everybody forgot about and left the plugin outdated with inconsistent logic?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions