Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google.protobuf.Duration converter to QTime #84

Open
semlanik opened this issue Jan 31, 2020 · 3 comments
Open

Add google.protobuf.Duration converter to QTime #84

semlanik opened this issue Jan 31, 2020 · 3 comments
Labels
feature New feature to be implemented protobuf QtProtobuf related issues

Comments

@semlanik
Copy link
Owner

No description provided.

@semlanik semlanik added protobuf QtProtobuf related issues feature New feature to be implemented labels Jan 31, 2020
@semlanik semlanik added this to the v0.4.0 milestone Jan 31, 2020
@unC0Rr
Copy link

unC0Rr commented May 3, 2020

QTime is just a time part of QDateTime. It makes most sense to convert to std::duration instead.

@semlanik
Copy link
Owner Author

@unC0Rr the idea is to provide deeper integration with Qt, std::duration is not part of Qt metaobject system. Overall not sure how useful will be such convertors, but hope it will be easier to use QTime instead of google.protobuf.Duration in some cases.

@unC0Rr
Copy link

unC0Rr commented May 11, 2020

Yeah, I understand the idea, but Qt itself has no means to express durations, and probably the only place you can find them in Qt is timer periods, which accept std::duration.

@semlanik semlanik modified the milestones: v0.4.0, v0.5.0 Jun 18, 2020
@semlanik semlanik removed this from the v0.5.0 milestone Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature to be implemented protobuf QtProtobuf related issues
Projects
None yet
Development

No branches or pull requests

2 participants