Skip to content

Commit 8040f2c

Browse files
Changes to follow SF bundle best practices (#19)
1 parent 93de626 commit 8040f2c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "sensiolabs/typescript-bundle",
33
"description": "TypeScript support for Symfony + AssetMapper",
44
"license": "MIT",
5-
"type": "library",
5+
"type": "symfony-bundle",
66
"keywords": ["asset-mapper", "typescript"],
77
"authors": [
88
{

config/services.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,35 +13,35 @@
1313

1414
return static function (ContainerConfigurator $container) {
1515
$container->services()
16-
->set('typescript.builder', TypeScriptBuilder::class)
16+
->set('sensiolabs_typescript.builder', TypeScriptBuilder::class)
1717
->args([
1818
abstract_arg('path to typescript files'),
1919
abstract_arg('path to compiled directory'),
2020
param('kernel.project_dir'),
2121
abstract_arg('path to the swc binary'),
2222
])
23-
->set('typescript.command.build', TypeScriptBuildCommand::class)
23+
->set('sensiolabs_typescript.command.build', TypeScriptBuildCommand::class)
2424
->args([
25-
service('typescript.builder')
25+
service('sensiolabs_typescript.builder')
2626
])
2727
->tag('console.command')
28-
->set('typescript.js_asset_compiler', TypeScriptCompiler::class)
28+
->set('sensiolabs_typescript.js_asset_compiler', TypeScriptCompiler::class)
2929
->tag('asset_mapper.compiler', [
3030
// A priority needs to be set to ensure that the TypeScript compiler is called before the JavaScript compiler
3131
'priority' => 10
3232
])
3333
->args([
3434
abstract_arg('path to typescript source dir'),
3535
abstract_arg('path to typescript output directory'),
36-
service('typescript.builder'),
36+
service('sensiolabs_typescript.builder'),
3737
])
38-
->set('typescript.public_asset_path_resolver', TypeScriptPublicPathAssetPathResolver::class)
38+
->set('sensiolabs_typescript.public_asset_path_resolver', TypeScriptPublicPathAssetPathResolver::class)
3939
->decorate('asset_mapper.public_assets_path_resolver')
4040
->args([
4141
service('.inner')
4242
])
43-
->set('typescript.pre_assets_compile_listener', PreAssetsCompileListener::class)
44-
->args([service('typescript.builder')])
43+
->set('sensiolabs_typescript.pre_assets_compile_listener', PreAssetsCompileListener::class)
44+
->args([service('sensiolabs_typescript.builder')])
4545
->tag('kernel.event_listener', [
4646
'event' => PreAssetsCompileEvent::class,
4747
'method' => '__invoke'

src/DependencyInjection/SensiolabsTypeScriptExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ public function load(array $configs, ContainerBuilder $container): void
2525
$configuration = $this->getConfiguration($configs, $container);
2626
$config = $this->processConfiguration($configuration, $configs);
2727

28-
$container->findDefinition('typescript.builder')
28+
$container->findDefinition('sensiolabs_typescript.builder')
2929
->replaceArgument(0, $config['source_dir'])
3030
->replaceArgument(1, '%kernel.project_dir%/var/typescript')
3131
->replaceArgument(3, $config['binary']);
3232

33-
$container->findDefinition('typescript.js_asset_compiler')
33+
$container->findDefinition('sensiolabs_typescript.js_asset_compiler')
3434
->replaceArgument(0, $config['source_dir'])
3535
->replaceArgument(1, '%kernel.project_dir%/var/typescript')
3636
->replaceArgument(2, '%kernel.project_dir%');

0 commit comments

Comments
 (0)