improve error handling

Author: sensorario

creational/abstract_factory/factory.go

@@ -1,7 +1,6 @@
 package factory
 
 import (
-	"errors"
 	"fmt"
 )
 
@@ -53,14 +52,14 @@ func (i *ItalianFactory) Build(v int) (Vehicle, error) {
 	case CarWithFiveWheelModel:
 		return new(CarWithFiveWheelType), nil
 	}
-	return nil, errors.New(fmt.Sprintf("No Italian cars of type %d\n", v))
+	return nil, fmt.Errorf("No Italian cars of type %d\n", v)
 }
 
 func BuildFactory(f int) (VehicleFactory, error) {
 	switch f {
 	case ItalianType:
 		return new(ItalianFactory), nil
 	default:
-		return nil, errors.New(fmt.Sprintf("No factory with id %d\n", f))
+		return nil, fmt.Errorf("No factory with id %d\n", f)
 	}
 }

creational/factory/factory.go

@@ -1,6 +1,6 @@
 package factory
 
-import "errors"
+import "fmt"
 
 const (
 	Italian = 1
@@ -18,9 +18,9 @@ func GetTranslator(m int) (Translator, error) {
 	case English:
 		return new(EnglishGreeting), nil
 	default:
-		return nil, errors.New("Unknown building")
+		return nil, fmt.Errorf("Unknown building")
 	}
-	return nil, errors.New("Not implemented yet")
+	return nil, fmt.Errorf("Not implemented yet")
 }
 
 type ItalianGreeting struct{}

creational/prototype/prototype.go

@@ -1,6 +1,6 @@
 package prototype
 
-import "errors"
+import "fmt"
 
 type ShirtCloner interface {
 	GetClone(s int) (ItemInfoGetter, error)
@@ -24,7 +24,7 @@ func (s *ShirtsCache) GetClone(m int) (ItemInfoGetter, error) {
 		newItem := *whitePrototype
 		return &newItem, nil
 	}
-	return nil, errors.New("Not implemented yet")
+	return nil, fmt.Errorf("Not implemented yet")
 }
 
 type ItemInfoGetter interface {

runtests.sh

@@ -1,7 +1,2 @@
 #!/bin/bash
-go test creational/abstract_factory/*.go
-go test creational/builder/*.go
-go test creational/factory/*.go
-go test creational/pool/*.go
-go test creational/prototype/*.go
-go test creational/singleton/*.go
+go test ./...