Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForTask Un-marshalled as DoTask #226

Open
reiniervl opened this issue Mar 6, 2025 · 2 comments
Open

ForTask Un-marshalled as DoTask #226

reiniervl opened this issue Mar 6, 2025 · 2 comments
Assignees
Labels
area:impl bug 🐛 Something isn't working

Comments

@reiniervl
Copy link

https://github.com/serverlessworkflow/sdk-go/blame/ff500a090258a53544b6e5451518d390e62936cc/model/task.go#L133

When un-marshalling a workflow that includes a ForTask, the task is un-marshalled as a DoTask, because the ForTask has the "do" key too, which is first in the list of the type registry. Placing the ForTask constructor with the "for" key above "do", would most likely fix the issue.

@ricardozanini
Copy link
Member

@reiniervl I fixed this here: #224

As soon as I merge that PR should be fine :)

If you need it asap, you can open a PR with the fix.

@ricardozanini
Copy link
Member

@reiniervl mind checking it again?

@ricardozanini ricardozanini added the bug 🐛 Something isn't working label Mar 25, 2025
@ricardozanini ricardozanini self-assigned this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:impl bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants