make check is failing with "Illegal instruction"

[nham]

As part of running make check on servo, tests in rust-geom are failing. This is what I get:

: ./geom-test 

running 9 tests
test length::tests::test_length ... ok
test matrix::test_ortho ... ok
test rect::test_contains ... ok
test rect::test_intersection ... ok
test rect::test_min_max ... ok
test rect::test_union ... ok
test rect::test_translate ... ok
test scale_factor::tests::test_scale_factor ... ok
Illegal instruction

It appears that the failing test is side_offsets::test_is_zero.

Since this seems to have something to do with the inline assembly in is_zero, you probably want something about my processor information? I'm not sure exactly what you need. My OS is 64-bit Arch Linux.

[nham]

I'm not too familiar with this stuff, but after further research I think that the ptest instruction in is_zero is an instruction for SSE4.1. I'm on a netbook with an AMD C-60 processor, which does not support this.

[jdm]

@bjz: you wrote the assembly, right?

Ran into this on a Core2 Duo (SSSE3 only).

[frewsxcv]

I think it might be safe to close this since this hasn't been reported in a while.

[pmarcelll]

A redditor pointed out (probably @Jurily) that this is still an issue, the code contains a PTEST SSE4 instruction here, but the function on older x86_64 platforms without SSE4 causes an "Illegal instruction" error.

[frewsxcv]

@pmarcelll Can you link to the comment in question?

[pmarcelll]

@frewsxcv Sure, you can see the whole conversation here.

[pmarcelll]

I did a bit of research and I found rust-lang/rust#29717. target_feature is still unstable, but locally it works (I changed #[cfg(target_arch = "x86_64")] to #[cfg(target_feature = "sse4.1")]).
The other option is rewriting the assembly, but I can't really help with that.