Upgrade ForeignTypes to grab ForeignType::into_ptr #2297
Comments
|
I believe it's stuck at an old version, because bumping it is considered semver breaking. So there's a general expectation that we'll upgrade the next time we do a semver version bump for the |
|
Makes sense, thanks. When that time comes, feel free to hit me up |
|
Sure. I'm not sure what @sfackler is thinking in terms of when to do a semver bump release. |
|
I think it's probably a good time to cut a version bump - CentOS 7 is EOL so we can drop 1.0.2 support. |
|
Would the plan be to drop it in openssl, but keep it in openssl-sys?
…On Wed, Sep 4, 2024, 9:04 AM Steven Fackler ***@***.***> wrote:
I think it's probably a good time to cut a version bump - CentOS 7 is EOL
so we can drop 1.0.2 support.
—
Reply to this email directly, view it on GitHub
<#2297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBB5X3DQ5UO6QZ5VC7DZU4AONAVCNFSM6AAAAABNUEYHTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYHE3TQNJYGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I definitely don't want to cut a breaking openssl-sys release. I think we'll probably just want to try to avoid regressing the 1.0.x bindings there but it'd probably not worth putting a ton of effort into that. |
|
On Wed, Sep 04, 2024 at 06:04:39AM -0700, Steven Fackler wrote:
I think it's probably a good time to cut a version bump - CentOS 7 is EOL so we can drop 1.0.2 support.
Maybe you could consider dropping support for a few ancient libressl
versions at the same time?
I occasionally still see reports of people running old macOS having
2.8.x installed, but everything older than that should really not be
used by anyone anymore.
|
|
Yeah, we'll want to clean up LibreSSL versions as well. |
|
I'll file a tracking issue for "stuff we want to do in 0.11. |
We pull in ForeignTypes version 5 in the boring crate, which let us get rid of some manual
mem::forgets on pointers for which we pass ownership to boringssl. Here's the PR and some background discussion. Is it worth upgrading ForeignTypes here to grab the same benefit, or is there a reason the dep is pinned to 0.3.1? Happy to do the work if we want to bumpThe text was updated successfully, but these errors were encountered: