Remove unnecessary react-intl SSR safeguards and fix Turbo test

- Removed SSR safeguards from react-intl usage in JSX components
  - These safeguards were added during initial beta.4 migration
  - They're not necessary for the shakapacker v9 upgrade
  - Simplified code by using destructured formatMessage directly
- Fixed failing Turbo/Stimulus inline form test
  - Added explicit wait time for Turbo frame update to complete
  - Test now properly waits for async Turbo frame navigation

All tests passing (38 examples, 0 failures)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: justin808

client/app/bundles/comments/components/CommentBox/CommentBox.jsx

@@ -74,8 +74,7 @@ class CommentBox extends BaseComponent {
 
   render() {
     const { actions, data, intl } = this.props;
-    // Safeguard for SSR where intl might not be properly initialized
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
     const cssTransitionGroupClassNames = {
       enter: css.elementEnter,
       enterActive: css.elementEnterActive,

client/app/bundles/comments/components/CommentBox/CommentForm/CommentForm.jsx

@@ -101,9 +101,8 @@ class CommentForm extends BaseComponent {
   }
 
   formHorizontal() {
-    // Safeguard for SSR where intl might not be properly initialized
     const { intl } = this.props;
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
     return (
       <div>
         <hr />
@@ -158,9 +157,8 @@ class CommentForm extends BaseComponent {
   }
 
   formStacked() {
-    // Safeguard for SSR where intl might not be properly initialized
     const { intl } = this.props;
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
     return (
       <div>
         <hr />
@@ -215,9 +213,8 @@ class CommentForm extends BaseComponent {
 
   // Head up! We have some CSS modules going on here with the className props below.
   formInline() {
-    // Safeguard for SSR where intl might not be properly initialized
     const { intl } = this.props;
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
     return (
       <div>
         <hr />
@@ -320,9 +317,8 @@ class CommentForm extends BaseComponent {
         throw new Error(`Unknown form mode: ${this.state.formMode}.`);
     }
 
-    // Safeguard for SSR where intl might not be properly initialized
     const { intl } = this.props;
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
 
     // For animation with TransitionGroup
     //   https://reactcommunity.org/react-transition-group/transition-group

client/app/bundles/comments/components/SimpleCommentScreen/ror_components/SimpleCommentScreen.jsx

@@ -72,8 +72,7 @@ class SimpleCommentScreen extends BaseComponent {
 
   render() {
     const { handleSetLocale, locale, intl } = this.props;
-    // Safeguard for SSR where intl might not be properly initialized
-    const formatMessage = intl && intl.formatMessage ? intl.formatMessage : (msg) => msg.defaultMessage || '';
+    const { formatMessage } = intl;
     const cssTransitionGroupClassNames = {
       enter: css.elementEnter,
       enterActive: css.elementEnterActive,

spec/stimulus/turbo_spec.rb

@@ -19,7 +19,7 @@
 
     it "shows inline form when Inline Form link is clicked" do
       click_link("Inline Form")
-      expect(page).to have_css(".form-inline")
+      expect(page).to have_css(".form-inline", wait: 5)
     end
 
     it "shows stacked form when Stacked Form link is clicked" do