Skip to content

Commit 421cef2

Browse files
committed
Addrees suggest comments from PR
1 parent 208dc62 commit 421cef2

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ gem "coffee-rails"
1818
# See https://github.com/sstephenson/execjs#readme for more supported runtimes
1919
# gem "therubyracer", platforms: :ruby
2020

21-
# jquery as the JavaScript library has been moved under /client and managed by npm
21+
# jquery as the JavaScript library has been moved under /client and managed by npm.
22+
# It is critical to not include any of the jquery gems when following this pattern or
23+
# else you might have multiple jQuery versions.
2224

2325
# Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
2426
gem "turbolinks"

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,9 @@ jQuery and jQuery-ujs are not required within `app/assets/javascript/application
178178
and have been moved under`/client` and managed by npm. The modules are exposed via entry point
179179
by `webpack.common.config.js`.
180180

181+
In `application.js`, it's critical that any libraries that depend on jQuery come after the inclusion
182+
of the Webpack bundle, such as the twitter bootstrap javascript.
183+
181184
Please refer to [Considerations for jQuery with Rails and Webpack](http://forum.railsonmaui.com/t/considerations-for-jquery-with-rails-and-webpack/344) for further info.
182185

183186

0 commit comments

Comments
 (0)