Skip to content

Commit 5eb4541

Browse files
justin808claude
andcommitted
Exclude binaries check from knip to fix CI build
Knip doesn't have a GitHub Actions plugin, so it reports binaries referenced in workflow files as "unlisted binaries" errors. Since build:test and test:e2e are legitimate package.json scripts used in the Playwright workflow, we exclude the binaries check. Changes: - Add --exclude binaries flag to both knip commands in CI - This allows knip to check for dead code, dependencies, and exports while ignoring the expected unlisted binaries warning 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 59ae12c commit 5eb4541

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/lint-js-and-ruby.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ jobs:
107107
run: cd spec/dummy && RAILS_ENV="test" bundle exec rake react_on_rails:generate_packs
108108
- name: Detect dead code
109109
run: |
110-
yarn run knip
111-
yarn run knip --production
110+
yarn run knip --exclude binaries
111+
yarn run knip --production --exclude binaries
112112
- name: Lint JS
113113
run: yarn run eslint --report-unused-disable-directives
114114
- name: Check formatting

0 commit comments

Comments
 (0)