From 13a1aca19950b5cb0c60d867e13cd62e64e83fce Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Sun, 9 Nov 2025 12:24:55 -1000 Subject: [PATCH] Remove misleading TODO comment about shakapacker.yml integration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The TODO referenced automatic detection of server_bundle_output_path from shakapacker.yml, but this feature was never implemented and may not be feasible as originally conceived. Why this TODO is being removed: 1. The referenced feature/shakapacker-yml-integration branch did not contain the implementation - it only had the foundational work which was already merged via PRs #1798 and #1815 2. Shakapacker.yml's public_output_path serves a different purpose than React on Rails' server_bundle_output_path (public webpack output vs private server bundle security) 3. The current configuration approach is working well The server bundle security features (server_bundle_output_path and enforce_private_server_bundles) are fully implemented and tested on master. Closes #1808 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- lib/react_on_rails/configuration.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/react_on_rails/configuration.rb b/lib/react_on_rails/configuration.rb index ffe707ad6c..76c69e5c87 100644 --- a/lib/react_on_rails/configuration.rb +++ b/lib/react_on_rails/configuration.rb @@ -51,9 +51,6 @@ def self.configuration server_bundle_output_path: "ssr-generated", enforce_private_server_bundles: false ) - # TODO: Add automatic detection of server_bundle_output_path from shakapacker.yml - # See feature/shakapacker-yml-integration branch for implementation - # Requires Shakapacker v8.5.0+ and semantic version checking end class Configuration