-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logging in native code #38
Comments
Removing logging doesn't seem like a good idea. Why would you want that? It helps you to follow the flow in the native code (can't really debug it or at least nobody knows how to) |
Ideally the project would be stable enough at some point to not require any logging at all, or where appropriate detailed exceptions are thrown. Log ouput might also reveal sensitive information, it would be better to let the user choose how they want to handle exceptions and what (if any) they want to log. Additionally depending on your setup you might not even be able to read the log if you run this library without capturing the standard output/error stream. Currently with these log statements the build log looks like this: |
I agree. That's too verbose. But I also agree that it can be nice to have verbose logging like this during debugging. Perhaps a |
The native code uses logging (
NSLog
) quite extensively. I am not familiar with Objective-C, but the documentation for this function says:However, it is currently used for debug logging as well. And it is used in cases where a Java exception is thrown anyways so logging seems redundant (instead the exception message should be improved, if necessary).
Therefore I would recommend completely removing logging.
Note: It appears the build process was slightly incorrect, using an outdated
libjcocoa.dylib
, see 8266cd9. Therefore you might not have seen logging output yet.The text was updated successfully, but these errors were encountered: