Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear assertion errors due to floating point numbers #567

Open
Goju-Ryu opened this issue Sep 17, 2024 · 1 comment
Open

Unclear assertion errors due to floating point numbers #567

Goju-Ryu opened this issue Sep 17, 2024 · 1 comment

Comments

@Goju-Ryu
Copy link
Contributor

I recently encountered a an error message that asserted that two identically printed values were not the same. I know this is due to floating point numbers being imperfect representations, but from a user perspective I thought we might want to point it out to the user that this is probably what went wrong.

I would suggest that we check for the two printed values, and if they are the exact same, we point out that floating point imprecision might be the cause. This will especially be helpful for less technical people so they don't assume it's a bug in numbat.

See an example here

image

@sharkdp
Copy link
Owner

sharkdp commented Sep 18, 2024

Great idea, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants