Skip to content

The default config file is not cacheable #55

@j3j5

Description

@j3j5

Trying to run php artisan config:cache on a project with this package installed fails because commit 10c3a1f introduced a not serializable value on the config file. The logger is now created on the config file instead of on the Service Provider.

Unless you have a very good reason for this, I can make a PR moving that code back to the service provider and restoring the logPath and logLevel on the config file. I guess I could make it backwards compatible that only if you don't have the logger on the config file it gets created on the service provider.

Let me know what you think.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions