Skip to content

Commit ef2084c

Browse files
panagosg7facebook-github-bot
authored andcommitted
0.87.0 in xplat/js
Summary: allow-large-files Reviewed By: samwgoldman Differential Revision: D13230018 fbshipit-source-id: f07e2371a3b7382de0592cc7c7b20e7f4faa6889
1 parent 585f7b9 commit ef2084c

File tree

11 files changed

+38
-12
lines changed

11 files changed

+38
-12
lines changed

.flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ untyped-import
9898
untyped-type-import
9999

100100
[version]
101-
^0.86.0
101+
^0.87.0

.flowconfig.android

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ untyped-import
9898
untyped-type-import
9999

100100
[version]
101-
^0.86.0
101+
^0.87.0

Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
231231
return (
232232
<AndroidDrawerLayout
233233
{...props}
234+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
235+
* suppresses an error found when Flow v0.87 was deployed. To see the
236+
* error, delete this comment and run Flow. */
234237
ref={this._nativeRef}
235238
drawerWidth={this.props.drawerWidth}
236239
drawerPosition={this.props.drawerPosition}
@@ -322,18 +325,30 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
322325
* Native methods
323326
*/
324327
blur() {
328+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
329+
* suppresses an error found when Flow v0.87 was deployed. To see the
330+
* error, delete this comment and run Flow. */
325331
nullthrows(this._nativeRef.current).blur();
326332
}
327333

328334
focus() {
335+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
336+
* suppresses an error found when Flow v0.87 was deployed. To see the
337+
* error, delete this comment and run Flow. */
329338
nullthrows(this._nativeRef.current).focus();
330339
}
331340

332341
measure(callback: MeasureOnSuccessCallback) {
342+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
343+
* suppresses an error found when Flow v0.87 was deployed. To see the
344+
* error, delete this comment and run Flow. */
333345
nullthrows(this._nativeRef.current).measure(callback);
334346
}
335347

336348
measureInWindow(callback: MeasureInWindowOnSuccessCallback) {
349+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
350+
* suppresses an error found when Flow v0.87 was deployed. To see the
351+
* error, delete this comment and run Flow. */
337352
nullthrows(this._nativeRef.current).measureInWindow(callback);
338353
}
339354

@@ -342,6 +357,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
342357
onSuccess: MeasureLayoutOnSuccessCallback,
343358
onFail?: () => void,
344359
) {
360+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
361+
* suppresses an error found when Flow v0.87 was deployed. To see the
362+
* error, delete this comment and run Flow. */
345363
nullthrows(this._nativeRef.current).measureLayout(
346364
relativeToNativeNode,
347365
onSuccess,
@@ -350,6 +368,9 @@ class DrawerLayoutAndroid extends React.Component<Props, State> {
350368
}
351369

352370
setNativeProps(nativeProps: Object) {
371+
/* $FlowFixMe(>=0.87.0 site=react_native_android_fb) This comment
372+
* suppresses an error found when Flow v0.87 was deployed. To see the
373+
* error, delete this comment and run Flow. */
353374
nullthrows(this._nativeRef.current).setNativeProps(nativeProps);
354375
}
355376
}

Libraries/Utilities/__tests__/setAndForwardRef-test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ describe('setAndForwardRef', () => {
8888

8989
ReactTestRenderer.create(<TestComponentWithRef ref={createdRef} />);
9090

91+
/* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an
92+
* error found when Flow v0.87 was deployed. To see the error, delete this
93+
* comment and run Flow. */
9194
const val = createdRef.current && createdRef.current.testFunc();
9295

9396
expect(innerFuncCalled).toBe(true);

RNTester/js/TextInputExample.android.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,8 +315,6 @@ class SelectionExample extends React.Component<
315315
onChangeText={value => this.setState({value})}
316316
onSelectionChange={this.onSelectionChange.bind(this)}
317317
ref={textInput => (this._textInput = textInput)}
318-
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was
319-
* found when making Flow check .android.js files. */
320318
selection={this.state.selection}
321319
style={this.props.style}
322320
value={this.state.value}

ReactAndroid/src/androidTest/js/ScrollViewTestModule.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ type State = {|
8787
|};
8888

8989
class ScrollViewTestApp extends React.Component<Props, State> {
90+
/* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error
91+
* found when Flow v0.87 was deployed. To see the error, delete this comment
92+
* and run Flow. */
9093
scrollView = React.createRef();
9194
state = getInitialState();
9295

@@ -121,6 +124,9 @@ class ScrollViewTestApp extends React.Component<Props, State> {
121124
}
122125

123126
class HorizontalScrollViewTestApp extends React.Component<Props, State> {
127+
/* $FlowFixMe(>=0.87.0 site=react_native_fb) This comment suppresses an error
128+
* found when Flow v0.87 was deployed. To see the error, delete this comment
129+
* and run Flow. */
124130
scrollView = React.createRef();
125131
state = getInitialState();
126132

jest/preprocessor.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const nodeOptions = babelRegisterOnly.config([nodeFiles]);
3333

3434
babelRegisterOnly([]);
3535

36-
/* $FlowFixMe(site=react_native_oss) */
3736
const transformer = require('metro/src/reactNativeTransformer');
3837
module.exports = {
3938
process(src /*: string */, file /*: string */) {

local-cli/bundle/buildBundle.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
const log = require('../util/log').out('bundle');
1414
const Server = require('metro/src/Server');
1515

16-
/* $FlowFixMe(site=react_native_oss) */
1716
const outputBundle = require('metro/src/shared/output/bundle');
1817
const path = require('path');
1918
const saveAssets = require('./saveAssets');

local-cli/templates/HelloWorld/_flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
6767
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
6868

6969
[version]
70-
^0.86.0
70+
^0.87.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221
"eslint-plugin-prettier": "2.6.0",
222222
"eslint-plugin-react": "7.8.2",
223223
"eslint-plugin-react-native": "3.5.0",
224-
"flow-bin": "^0.86.0",
224+
"flow-bin": "^0.87.0",
225225
"jest": "24.0.0-alpha.6",
226226
"jest-junit": "5.2.0",
227227
"prettier": "1.13.6",

0 commit comments

Comments
 (0)