Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all products have 3D models #2

Open
shish opened this issue Aug 17, 2024 · 1 comment
Open

Not all products have 3D models #2

shish opened this issue Aug 17, 2024 · 1 comment

Comments

@shish
Copy link
Owner

shish commented Aug 17, 2024

Current behaviour of "show all search results, with no indication of which ones have models, then give a 404 error when the user tries to import one" is not ideal...

When browsing the website, the browser calls a "does a model exist for this product" API when you visit the product page, but there is nothing in the search results page. We could call the "does a model exist for this product" API for every item in the search results list, but that turns one API call into 20+ calls, which will slow down the experience for the user and increase load on ikea's website (only a tiny amount of load compared to the millions of users accessing the site normally, but still)

How much extra load / slowness can we justify having?

If we can know which ones have models, what do we do with that information?

  • Hide results without models? (cleaner)
  • Show results with the import button greyed out and a "no model available" message? (means that users won't waste time like "I know ikea has this product, why isn't it showing in the search results?")
@chrleon
Copy link

chrleon commented Sep 12, 2024

If the call is fast enough, what about checking the 'has model api' on hover? Or for only the ones visible in the list on the users screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants