Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on tough v0.19 pulls in rustls and aws-lc-sys whether you want them or not #436

Open
dave-tucker opened this issue Feb 14, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@dave-tucker
Copy link
Contributor

dave-tucker commented Feb 14, 2025

Description

We're using sigstore-rs to perform verification of cosign signatures on the public good instance.
We noticed that in sigstore-rs v0.11 that compilation fails for us on s390x and ppc64le due to a dependency on aws-lc-sys.
It turns out that some changes in tough v0.19 brought in aws-lc-rs, aws-lc-sys and rustls as dependencies, whether you want them or not.

In our case, we most certainly do not want them as we're using the native-tls feature pretty much everywhere and would like to avoid rustls if possible. The fix for this is likely upstream in awslabs/tough, but I wanted to first open an issue as I'm not exactly sure what the correct fix would be.

Version

sigstore-rs v0.11

@dave-tucker dave-tucker added the bug Something isn't working label Feb 14, 2025
Billy99 added a commit to Billy99/bpfman that referenced this issue Feb 14, 2025
PR bpfman#1406 bumped the version of sigstore from 0.10.0 to 0.11.0. That bump
also brought in a dependency on aws-lc-rs. Several subsequent PRs fixed
RPM build failures do to aws-lc-rs (bpfman#1407 and bpfman#1410). Now downstream
OpenShift builds of bpfman are failing on certain arches. Attempting a
workaround to the downstream failures by changing the asw-lc-rs feature
flags.

Ultimately, aws-lc-rs should not be a dependency, see:
sigstore/sigstore-rs#436

Signed-off-by: Billy McFall <[email protected]>
@jku
Copy link
Member

jku commented Feb 14, 2025

awslabs/tough#824 I suppose

@dave-tucker dave-tucker changed the title dependency on tough v0.14 pulls in rustls and aws-lc-sys whether you want them or not dependency on tough v0.19 pulls in rustls and aws-lc-sys whether you want them or not Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants