Impossible to disable flags that default to 'true'

[l3k4n]

For example in arigo.Options you have:

AutoFileRenaming              bool    `json:"auto-file-renaming,omitempty,string"`

This options default value is true and when it is set to false, the json serializer strips it out because it thinks it's empty. I believe this applies to basically all boolean options, making all default true options impossible to change.

This leaves one of 3 options:

1. make a custom type for on/off type options and explicitly handle the 'empty' case
2. make them all pointers
3. just drop, the omitempty

[l3k4n]

dropping the omitempty, would be a quickfix but I don't know how much effect that would have on payload side so I leave that decision to you

[siku2]

I wrote the bulk of this code 7 years ago. I couldn't possibly tell you why it was done this way :D
Both 2 and 3 sound like decent options to me. I would accept either as a PR.

[Nubuki-all]

dropping the omitempty, would be a quickfix but I don't know how much effect that would have on payload side so I leave that decision to you

It would infact break stuff for users relying on default behavior