fix tests

siltomato · siltomato · commit 18ec72f6f9f5 · 2025-10-24T11:30:48.000-04:00
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/chapter-audio-dialog/chapter-audio-dialog.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/chapter-audio-dialog/chapter-audio-dialog.component.spec.ts
@@ -368,7 +368,7 @@ describe('ChapterAudioDialogComponent', () => {
     // The "from" value of the next entry
     expect(result.timingData[0].to).toEqual(1.1);
     // The end of the audio file
-    expect(result.timingData[1].to).toEqual(1.32);
+    expect(result.timingData[1].to).toEqual(1.296);
   }));
 
   it('will not save or upload if there is no audio', fakeAsync(() => {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.spec.ts
@@ -39,7 +39,7 @@ const mockedFileService = mock(FileService);
 
 describe('QuestionDialogService', () => {
   configureTestingModule(() => ({
-    imports: [getTestTranslocoModule()],
+    imports: [getTestTranslocoModule(false)],
     providers: [
       provideTestRealtime(SF_TYPE_REGISTRY),
       { provide: FileService, useMock: mockedFileService },
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-projects.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-projects.component.ts
@@ -1,4 +1,5 @@
 import { Component, DestroyRef, OnInit } from '@angular/core';
+import { MatButton } from '@angular/material/button';
 import { MatFormField, MatLabel } from '@angular/material/form-field';
 import { MatIcon } from '@angular/material/icon';
 import { MatInput } from '@angular/material/input';
@@ -25,8 +26,8 @@ import { DataLoadingComponent } from 'xforge-common/data-loading-component';
 import { I18nService } from 'xforge-common/i18n.service';
 import { NoticeService } from 'xforge-common/notice.service';
 import { QueryParameters } from 'xforge-common/query-parameters';
+import { RouterLinkDirective } from 'xforge-common/router-link.directive';
 import { quietTakeUntilDestroyed } from 'xforge-common/util/rxjs-util';
-import { RouterLinkDirective } from '../../xforge-common/router-link.directive';
 import { SFProjectProfileDoc } from '../core/models/sf-project-profile-doc';
 import { projectLabel } from '../shared/utils';
 import { DraftSourcesAsTranslateSourceArrays, projectToDraftSources } from '../translate/draft-generation/draft-utils';
@@ -82,6 +83,7 @@ class Row {
   templateUrl: './serval-projects.component.html',
   styleUrls: ['./serval-projects.component.scss'],
   imports: [
+    MatButton,
     MatTable,
     MatColumnDef,
     MatHeaderCell,
@@ -159,7 +161,7 @@ export class ServalProjectsComponent extends DataLoadingComponent implements OnI
   }
 
   viewDraftJobs(projectId: string): void {
-    this.router.navigate(['/serval-administration'], {
+    void this.router.navigate(['/serval-administration'], {
       queryParams: {
         projectId,
         tab: 'draft-jobs'
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/shared/sf-tab-group/tab-group-header/tab-group-header.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/shared/sf-tab-group/tab-group-header/tab-group-header.component.ts
@@ -39,19 +39,19 @@ import { TabScrollButtonComponent } from './tab-scroll-button/tab-scroll-button.
   templateUrl: './tab-group-header.component.html',
   styleUrls: ['./tab-group-header.component.scss'],
   imports: [
-    TabScrollButtonComponent,
     CdkDropList,
-    NgFor,
-    TabHeaderComponent,
     CdkDrag,
+    NgFor,
+    NgIf,
     NgTemplateOutlet,
-    MatMenuTrigger,
+    AsyncPipe,
     MatIcon,
     MatMenu,
-    NgIf,
     MatMenuItem,
-    AsyncPipe,
-    TranslocoModule
+    MatMenuTrigger,
+    TranslocoModule,
+    TabHeaderComponent,
+    TabScrollButtonComponent
   ]
 })
 export class TabGroupHeaderComponent implements OnChanges, OnInit, AfterViewInit, OnDestroy {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-note-dialog/text-note-dialog.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-note-dialog/text-note-dialog.component.spec.ts
@@ -13,7 +13,7 @@ import { NoteDialogData, TextNoteDialogComponent, TextNoteType } from './text-no
 
 describe('TextNoteDialogComponent', () => {
   configureTestingModule(() => ({
-    imports: [getTestTranslocoModule(), TextNoteDialogComponent],
+    imports: [getTestTranslocoModule(false), TextNoteDialogComponent],
     providers: [provideNoopAnimations()]
   }));
   let env: TestEnvironment;
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/biblical-terms/biblical-terms.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/biblical-terms/biblical-terms.component.ts
@@ -1,4 +1,4 @@
-import { SlicePipe } from '@angular/common';
+import { NgFor, SlicePipe } from '@angular/common';
 import { Component, DestroyRef, ElementRef, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { MatIconButton } from '@angular/material/button';
@@ -195,6 +195,7 @@ class Row {
   templateUrl: './biblical-terms.component.html',
   styleUrls: ['./biblical-terms.component.scss'],
   imports: [
+    NgFor,
     FormsModule,
     TranslocoModule,
     MatTooltip,
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.spec.ts
@@ -78,7 +78,7 @@ describe('DraftGenerationComponent', () => {
       }
 
       TestBed.configureTestingModule({
-        imports: [, getTestTranslocoModule()],
+        imports: [getTestTranslocoModule()],
         providers: [
           provideRouter([]),
           provideTestOnlineStatus(),
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.ts
@@ -1,7 +1,7 @@
 import { AsyncPipe } from '@angular/common';
 import { HttpErrorResponse } from '@angular/common/http';
 import { Component, DestroyRef, OnInit, ViewChild } from '@angular/core';
-import { MatButton } from '@angular/material/button';
+import { MatAnchor, MatButton } from '@angular/material/button';
 import {
   MatCard,
   MatCardActions,
@@ -68,6 +68,7 @@ import { SupportedBackTranslationLanguagesDialogComponent } from './supported-ba
   styleUrls: ['./draft-generation.component.scss'],
   imports: [
     AsyncPipe,
+    MatAnchor,
     MatButton,
     MatIcon,
     MatCard,
@@ -231,7 +232,7 @@ export class DraftGenerationComponent extends DataLoadingComponent implements On
         const dialogRef = this.dialogService.openMatDialog(SupportedBackTranslationLanguagesDialogComponent);
 
         dialogRef.afterClosed().subscribe(() => {
-          this.router.navigate([], { fragment: undefined });
+          void this.router.navigate([], { fragment: undefined });
         });
       });
 
@@ -433,7 +434,7 @@ export class DraftGenerationComponent extends DataLoadingComponent implements On
         if (this.isDraftInProgress(job)) {
           this.draftJob = job;
           this.currentPage = 'initial';
-          this.dialogService.message('draft_generation.draft_already_running');
+          void this.dialogService.message('draft_generation.draft_already_running');
           return;
         }
       });
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-sources/draft-sources.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-sources/draft-sources.component.ts
@@ -1,3 +1,4 @@
+import { KeyValuePipe, NgTemplateOutlet } from '@angular/common';
 import { Component, DestroyRef, EventEmitter } from '@angular/core';
 import { MatButton } from '@angular/material/button';
 import { MatCard, MatCardActions, MatCardContent, MatCardHeader, MatCardTitle } from '@angular/material/card';
@@ -41,6 +42,7 @@ import {
 import { LanguageCodesConfirmationComponent } from '../language-codes-confirmation/language-codes-confirmation.component';
 import { TrainingDataMultiSelectComponent } from '../training-data/training-data-multi-select.component';
 import { TrainingDataService } from '../training-data/training-data.service';
+
 /** Status for a project, which may or may not be at SF. */
 export interface ProjectStatus {
   shortName: string;
@@ -53,6 +55,8 @@ export interface ProjectStatus {
 @Component({
   selector: 'app-draft-sources',
   imports: [
+    NgTemplateOutlet,
+    KeyValuePipe,
     MatButton,
     MatIcon,
     MatRipple,
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts
@@ -99,6 +99,7 @@ import { BuildStates } from '../../machine-api/build-states';
 import { HttpClient } from '../../machine-api/http-client';
 import { RemoteTranslationEngine } from '../../machine-api/remote-translation-engine';
 import { CopyrightBannerComponent } from '../../shared/copyright-banner/copyright-banner.component';
+import { provideCustomIcons } from '../../shared/custom-icons';
 import {
   provideSFTabs,
   TabComponent,
@@ -180,14 +181,14 @@ describe('EditorComponent', () => {
       BiblicalTermsComponent,
       CopyrightBannerComponent,
       DraftPreviewBooksComponent,
-      getTestTranslocoModule(),
-      TranslocoMarkupModule,
       TabGroupComponent,
       TabComponent,
       TabHeaderDirective,
       LynxInsightEditorObjectsComponent,
       LynxInsightsPanelComponent,
-      AngularSplitModule
+      AngularSplitModule,
+      getTestTranslocoModule(),
+      TranslocoMarkupModule
     ],
     providers: [
       provideRouter(ROUTES),
@@ -196,6 +197,7 @@ describe('EditorComponent', () => {
       provideTestRealtime(SF_TYPE_REGISTRY),
       provideSFTabs(),
       provideLynxInsights(),
+      provideCustomIcons(),
       { provide: AuthService, useMock: mockedAuthService },
       { provide: SFProjectService, useMock: mockedSFProjectService },
       { provide: UserService, useMock: mockedUserService },
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts
@@ -247,40 +247,40 @@ const UNSUPPORTED_LANGUAGE_CODES = [
     { provide: TabAddRequestService, useClass: EditorTabAddRequestService }
   ],
   imports: [
-    TranslocoModule,
-    BookChapterChooserComponent,
+    AsyncPipe,
+    Dir,
+    KeyValuePipe,
     NgClass,
+    FormsModule,
+    ReactiveFormsModule,
+    MatButton,
+    MatFormField,
+    MatIcon,
     MatIconButton,
-    BlurOnClickDirective,
+    MatInput,
+    MatLabel,
+    MatMiniFabButton,
     MatTooltip,
-    MatIcon,
-    ShareButtonComponent,
+    AngularSplitModule,
+    TranslocoModule,
+    BlurOnClickDirective,
+    BookChapterChooserComponent,
+    CopyrightBannerComponent,
     MultiViewerComponent,
-    TabGroupComponent,
+    NoticeComponent,
+    ShareButtonComponent,
+    TextComponent,
     TabComponent,
+    TabGroupComponent,
     TabHeaderDirective,
     BiblicalTermsComponent,
+    EditorDraftComponent,
+    EditorHistoryComponent,
     EditorResourceComponent,
-    CopyrightBannerComponent,
-    TextComponent,
-    NoticeComponent,
-    AngularSplitModule,
-    Dir,
-    SuggestionsComponent,
-    MatButton,
-    FormsModule,
-    MatFormField,
-    MatLabel,
-    MatInput,
-    ReactiveFormsModule,
-    MatMiniFabButton,
     LynxInsightsPanelComponent,
-    EditorHistoryComponent,
-    EditorDraftComponent,
-    TrainingProgressComponent,
-    AsyncPipe,
-    KeyValuePipe,
-    TextDocIdPipe
+    SuggestionsComponent,
+    TextDocIdPipe,
+    TrainingProgressComponent
   ]
 })
 export class EditorComponent extends DataLoadingComponent implements OnDestroy, OnInit, AfterViewInit {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-editor-objects/lynx-insight-editor-objects.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-editor-objects/lynx-insight-editor-objects.component.spec.ts
@@ -1,11 +1,13 @@
 import { Component, DestroyRef, NO_ERRORS_SCHEMA, ViewChild } from '@angular/core';
 import { ComponentFixture, fakeAsync, flush, TestBed, tick } from '@angular/core/testing';
 import { Delta } from 'quill';
+import { LynxInsightFilter, LynxInsightType } from 'realtime-server/lib/esm/scriptureforge/models/lynx-insight';
 import { BehaviorSubject } from 'rxjs';
 import { anything, instance, mock, verify, when } from 'ts-mockito';
 import { ActivatedBookChapterService, RouteBookChapter } from 'xforge-common/activated-book-chapter.service';
 import { configureTestingModule } from 'xforge-common/test-utils';
 import { TextDocId } from '../../../../../core/models/text-doc';
+import { provideCustomIcons } from '../../../../../shared/custom-icons';
 import { EditorReadyService } from '../base-services/editor-ready.service';
 import { InsightRenderService } from '../base-services/insight-render.service';
 import {
@@ -35,6 +37,7 @@ describe('LynxInsightEditorObjectsComponent', () => {
   configureTestingModule(() => ({
     imports: [HostComponent, LynxInsightEditorObjectsComponent],
     providers: [
+      provideCustomIcons(),
       { provide: InsightRenderService, useMock: mockInsightRenderService },
       { provide: LynxInsightStateService, useMock: mockInsightStateService },
       { provide: EditorReadyService, useMock: mockEditorReadyService },
@@ -384,8 +387,8 @@ class TestEnvironment {
   private filteredInsightsSubject: BehaviorSubject<LynxInsight[]>;
   private displayStateSubject: BehaviorSubject<LynxInsightDisplayState>;
   private activatedBookChapterSubject: BehaviorSubject<RouteBookChapter | undefined>;
-  private filterSubject: BehaviorSubject<any>;
-  private filteredInsightCountsByTypeSubject: BehaviorSubject<any>;
+  private filterSubject: BehaviorSubject<LynxInsightFilter>;
+  private filteredInsightCountsByTypeSubject: BehaviorSubject<Record<LynxInsightType, number>>;
   private taskRunningStatusSubject: BehaviorSubject<boolean>;
 
   constructor(args: TestEnvArgs = {}) {
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-status-indicator/lynx-insight-status-indicator.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-status-indicator/lynx-insight-status-indicator.component.spec.ts
@@ -6,6 +6,7 @@ import { LynxInsightType } from 'realtime-server/lib/esm/scriptureforge/models/l
 import { BehaviorSubject } from 'rxjs';
 import { mock, verify, when } from 'ts-mockito';
 import { configureTestingModule } from 'xforge-common/test-utils';
+import { provideCustomIcons } from '../../../../../shared/custom-icons';
 import { LynxInsightStateService } from '../lynx-insight-state.service';
 import { LynxWorkspaceService } from '../lynx-workspace.service';
 import { LynxInsightStatusIndicatorComponent } from './lynx-insight-status-indicator.component';
@@ -17,6 +18,7 @@ describe('LynxInsightStatusIndicatorComponent', () => {
   configureTestingModule(() => ({
     imports: [LynxInsightStatusIndicatorComponent, MatIcon, HostComponent],
     providers: [
+      provideCustomIcons(),
       { provide: LynxInsightStateService, useMock: mockLynxInsightStateService },
       { provide: LynxWorkspaceService, useMock: mockLynxWorkspaceService }
     ]
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insights-panel/lynx-insights-panel.component.spec.ts b/src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insights-panel/lynx-insights-panel.component.spec.ts
@@ -124,6 +124,7 @@ describe('LynxInsightsPanelComponent', () => {
     ],
     schemas: [CUSTOM_ELEMENTS_SCHEMA],
     providers: [
+      provideNoopAnimations(),
       { provide: LynxInsightStateService, useMock: mockLynxInsightStateService },
       { provide: ActivatedProjectService, useMock: mockActivatedProjectService },
       { provide: ActivatedBookChapterService, useMock: mockActivatedBookChapterService },
@@ -134,7 +135,7 @@ describe('LynxInsightsPanelComponent', () => {
       {
         provide: EDITOR_INSIGHT_DEFAULTS,
         useValue: {
-          filter: { types: ['info', 'warning', 'error', provideNoopAnimations()], scope: 'chapter' },
+          filter: { types: ['info', 'warning', 'error'], scope: 'chapter' },
           sortOrder: 'severity',
           queryParamName: 'insight',
           actionOverlayApplyPrimaryActionChord: { altKey: true, shiftKey: true, key: 'Enter' },
diff --git a/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/test-utils.ts b/src/SIL.XForge.Scripture/ClientApp/src/xforge-common/test-utils.ts
@@ -60,25 +60,21 @@ export const configureTestingModule = (createModuleDef: () => TestModuleMetadata
   });
 };
 
-// export const TestTranslocoModule = TranslocoTestingModule.forRoot({
-//   langs: { en },
-//   translocoConfig: {
-//     availableLangs: ['en'],
-//     reRenderOnLangChange: true,
-//     fallbackLang: 'en',
-//     defaultLang: 'en'
-//   }
-// });
-
-export function getTestTranslocoModule(): ModuleWithProviders<TranslocoTestingModule> {
+/**
+ * Gets a Transloco testing module with 'en' translations loaded.
+ * @param loadLangs Whether to preload the languages. Set to false if tests want to use the untranslated key.
+ * Default is true.
+ */
+export function getTestTranslocoModule(loadLangs = true): ModuleWithProviders<TranslocoTestingModule> {
   return TranslocoTestingModule.forRoot({
     langs: { en },
     translocoConfig: {
       availableLangs: ['en'],
       reRenderOnLangChange: true,
       fallbackLang: 'en',
       defaultLang: 'en'
-    }
+    },
+    preloadLangs: loadLangs
   });
 }
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ describe('DraftGenerationComponent', () => {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`TestBed.configureTestingModule({`
`81`		`- imports: [, getTestTranslocoModule()],`
	`81`	`+ imports: [getTestTranslocoModule()],`
`82`	`82`	`providers: [`
`83`	`83`	`provideRouter([]),`
`84`	`84`	`provideTestOnlineStatus(),`