test: more accurately simulate a remote note change

Author: marksvc

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.spec.ts

@@ -31,6 +31,7 @@ import Quill, { Delta, EmitterSource, Range } from 'quill';
 import { User } from 'realtime-server/lib/esm/common/models/user';
 import { createTestUser } from 'realtime-server/lib/esm/common/models/user-test-data';
 import { WritingSystem } from 'realtime-server/lib/esm/common/models/writing-system';
+import { Json0OpBuilder } from 'realtime-server/lib/esm/common/utils/json0-op-builder';
 import { obj } from 'realtime-server/lib/esm/common/utils/obj-path';
 import { RecursivePartial } from 'realtime-server/lib/esm/common/utils/type-utils';
 import { BiblicalTerm } from 'realtime-server/lib/esm/scriptureforge/models/biblical-term';
@@ -70,6 +71,7 @@ import { CONSOLE } from 'xforge-common/browser-globals';
 import { BugsnagService } from 'xforge-common/bugsnag.service';
 import { createTestFeatureFlag, FeatureFlagService } from 'xforge-common/feature-flags/feature-flag.service';
 import { GenericDialogComponent, GenericDialogOptions } from 'xforge-common/generic-dialog/generic-dialog.component';
+import { MemoryRealtimeDocAdapter } from 'xforge-common/memory-realtime-remote-store';
 import { UserDoc } from 'xforge-common/models/user-doc';
 import { NoticeService } from 'xforge-common/notice.service';
 import { OnlineStatusService } from 'xforge-common/online-status.service';
@@ -3373,7 +3375,7 @@ describe('EditorComponent', () => {
       env.dispose();
     }));
 
-    it('should remove resolved notes after a remote update', fakeAsync(() => {
+    it('should remove resolved notes after a remote update', fakeAsync(async () => {
       const env = new TestEnvironment();
       env.setProjectUserConfig();
       env.wait();
@@ -3382,7 +3384,7 @@ describe('EditorComponent', () => {
       let noteThreadEmbedCount = env.countNoteThreadEmbeds(contents.ops!);
       expect(noteThreadEmbedCount).toEqual(5);
 
-      env.resolveNote('project01', 'dataid01');
+      await env.resolveNote('project01', 'dataid01', 'remote');
       contents = env.targetEditor.getContents();
       noteThreadEmbedCount = env.countNoteThreadEmbeds(contents.ops!);
       expect(noteThreadEmbedCount).toEqual(4);
@@ -5594,10 +5596,19 @@ class TestEnvironment {
     return noteEmbedCount;
   }
 
-  resolveNote(projectId: string, threadId: string): void {
+  async resolveNote(projectId: string, threadId: string, origin: 'local' | 'remote'): Promise<void> {
     const noteDoc: NoteThreadDoc = this.getNoteThreadDoc(projectId, threadId);
-    noteDoc.submitJson0Op(op => op.set(n => n.status, NoteStatus.Resolved));
-    this.realtimeService.updateQueryAdaptersRemote();
+    const ops = op => op.set(n => n.status, NoteStatus.Resolved);
+
+    if (origin === 'remote') {
+      const docAdapter: MemoryRealtimeDocAdapter = noteDoc.adapter as MemoryRealtimeDocAdapter;
+      const builder = new Json0OpBuilder(noteDoc.data);
+      ops(builder);
+      const operations = builder.op;
+      this.realtimeService.simulateRemoteChange(docAdapter, operations);
+    } else {
+      await noteDoc.submitJson0Op(ops);
+    }
     this.wait();
   }
 

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/memory-realtime-remote-store.ts

@@ -17,6 +17,8 @@ export class MemoryRealtimeRemoteStore extends RealtimeRemoteStore {
     // getAccessToken is not used in this memory implementation
   }
 
+  /** Write a realtime doc into the store, for a given collection. An existing realtime doc with the same id is
+   * overwritten. */
   addSnapshot<T>(collection: string, snapshot: Snapshot<T>): void {
     let collectionSnapshots = this.snapshots.get(collection);
     if (collectionSnapshots == null) {
@@ -132,7 +134,7 @@ export class MemoryRealtimeDocAdapter implements RealtimeDocAdapter {
     return Promise.resolve();
   }
 
-  submitOp(op: any, source?: any): Promise<void> {
+  submitOpWithoutEmitting(op: any): void {
     if (this.type == null) {
       throw new Error('The doc has not been loaded.');
     }
@@ -143,6 +145,11 @@ export class MemoryRealtimeDocAdapter implements RealtimeDocAdapter {
     }
     this.data = this.type.apply(this.data, op);
     this.version++;
+  }
+
+  /** Multiple operations are received for the `op` argument. */
+  submitOp(op: any, source?: any): Promise<void> {
+    this.submitOpWithoutEmitting(op);
     this.emitChange(op);
     if (!source) {
       this.emitRemoteChange(op);

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/test-realtime.service.ts

@@ -2,7 +2,11 @@ import { Injectable } from '@angular/core';
 import { merge } from 'lodash-es';
 import * as OTJson0 from 'ot-json0';
 import { MemoryOfflineStore } from './memory-offline-store';
-import { MemoryRealtimeQueryAdapter, MemoryRealtimeRemoteStore } from './memory-realtime-remote-store';
+import {
+  MemoryRealtimeDocAdapter,
+  MemoryRealtimeQueryAdapter,
+  MemoryRealtimeRemoteStore
+} from './memory-realtime-remote-store';
 import { FileOfflineData, FileType } from './models/file-offline-data';
 import { Snapshot } from './models/snapshot';
 import { RealtimeService } from './realtime.service';
@@ -33,6 +37,8 @@ export class TestRealtimeService extends RealtimeService {
     }
   }
 
+  /** Write a realtime doc into the store, for a given collection. An existing realtime doc with the same id is
+   * overwritten. */
   addSnapshot<T>(collection: string, snapshot: Partial<Snapshot<T>>, addToOfflineStore: boolean = false): void {
     const completeSnapshot = addSnapshotDefaults(snapshot);
     (this.remoteStore as MemoryRealtimeRemoteStore).addSnapshot(collection, completeSnapshot);
@@ -57,6 +63,37 @@ export class TestRealtimeService extends RealtimeService {
     }
   }
 
+  /** Intended to do the same thing as `updateQueryAdaptersRemote` but without remoteChanges$ emitting, which can be
+   * done in follow up. */
+  updateQueryAdaptersRemoteQuietly(): MemoryRealtimeQueryAdapter[] {
+    const adaptersToEmit: MemoryRealtimeQueryAdapter[] = [];
+    for (const collectionQueries of this.subscribeQueries.values()) {
+      for (const query of collectionQueries) {
+        const adapter = query.adapter as MemoryRealtimeQueryAdapter;
+        if ((adapter as any).performQuery()) {
+          adaptersToEmit.push(adapter);
+        }
+      }
+    }
+    return adaptersToEmit;
+  }
+
+  /** Simulate a change happening externally. The MemoryRealtimeDocAdapter data and MemoryRealtimeQueryAdapter results
+   * are updated before changes are announced, so when changes begin to be announced, the docs and queries are all
+   * up-to-date. The order of emits, and presence or absence of RealtimeQuery.remoteDocChanges$, may be different than
+   * when running the app. */
+  async simulateRemoteChange(docAdapter: MemoryRealtimeDocAdapter, ops: any): Promise<void> {
+    // Submitting ops to the realtime doc adapter to simulate writing data on a remote server may seem backwards but
+    // is getting the job done.
+    docAdapter.submitOpWithoutEmitting(ops);
+    const queryAdaptersToEmit: MemoryRealtimeQueryAdapter[] = this.updateQueryAdaptersRemoteQuietly();
+    docAdapter.emitChange(ops);
+    docAdapter.emitRemoteChange(ops);
+    for (const adapter of queryAdaptersToEmit) {
+      adapter.remoteChanges$.next();
+    }
+  }
+
   async updateQueriesLocal(): Promise<void> {
     for (const collectionQueries of this.subscribeQueries.values()) {
       for (const query of collectionQueries) {