SF-3572 Inform user which books aren't available as training data (#3524)

Author: pmachapman

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html

@@ -191,11 +191,6 @@ <h2>{{ t("reference_books") }}</h2>
             {{ t("choose_books_for_training_error") }}
           </app-notice>
         }
-        @if (translatedBooksWithNoSource.length > 0) {
-          <app-notice class="warn-source-books-missing" type="warning" icon="warning">
-            {{ t("source_books_missing") }}
-          </app-notice>
-        }
         <div class="button-strip">
           <button mat-stroked-button matStepperPrevious>
             <mat-icon>chevron_{{ i18n.backwardDirectionWord }}</mat-icon>

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts

@@ -365,7 +365,7 @@ describe('DraftGenerationStepsComponent', () => {
       expect(component.unusableTranslateSourceBooks).toEqual([6]);
       expect(component.unusableTrainingSourceBooks).toEqual([6]);
       // warn when translated book has no source
-      expect(fixture.nativeElement.querySelector('.warn-source-books-missing')).not.toBeNull();
+      expect(fixture.nativeElement.querySelector('.unusable-training-books')).not.toBeNull();
     }));
 
     it('should set "emptyTranslateSourceBooks"', fakeAsync(() => {

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts

@@ -124,7 +124,6 @@ export class DraftGenerationStepsComponent implements OnInit {
   protected draftingSources: DraftSource[] = [];
   protected trainingSources: DraftSource[] = [];
   protected trainingTargets: DraftSource[] = [];
-  protected translatedBooksWithNoSource: number[] = [];
   protected trainingDataFiles: Readonly<TrainingData>[] = [];
 
   private trainingDataQuery?: RealtimeQuery<TrainingDataDoc>;
@@ -284,12 +283,6 @@ export class DraftGenerationStepsComponent implements OnInit {
               isPresentInASource = true;
             } else {
               this.unusableTrainingSourceBooks.push(bookNum);
-              const textProgress: TextProgress | undefined = this.progressService.texts.find(
-                t => t.text.bookNum === bookNum
-              );
-              if (textProgress != null && textProgress.translated > minimumTranslatedSegments) {
-                this.translatedBooksWithNoSource.push(bookNum);
-              }
             }
             if (trainingSources[1] != null && additionalTrainingSourceBooks.has(bookNum)) {
               this.availableTrainingBooks[trainingSources[1].projectRef].push({ number: bookNum, selected: selected });
@@ -349,7 +342,7 @@ export class DraftGenerationStepsComponent implements OnInit {
   }
 
   get firstTrainingSource(): string {
-    return this.trainingSources[0]?.shortName ?? '';
+    return projectLabel(this.trainingSources[0]);
   }
 
   get trainingSourceBooksSelected(): boolean {

src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json

@@ -254,7 +254,6 @@
     "reference_books": "Reference books",
     "remote_changes": "The source configuration for draft generation has been modified. Please start a new draft and review the latest source configuration.",
     "remote_changes_start_over": "Start over",
-    "source_books_missing": "The reference text is missing one or more of the translated books in your project. Consider choosing a reference text that contains a match for all the translated books",
     "summary_header": "Summary",
     "summary_notifications": "Notifications",
     "summary_title": "Summary",