Skip to content

Commit 7bc4625

Browse files
committed
fix tests
1 parent e9402f1 commit 7bc4625

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

src/SIL.XForge.Scripture/ClientApp/src/app/checking/question-dialog/question-dialog.service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const mockedFileService = mock(FileService);
3939

4040
describe('QuestionDialogService', () => {
4141
configureTestingModule(() => ({
42-
imports: [getTestTranslocoModule()],
42+
imports: [getTestTranslocoModule(false)],
4343
providers: [
4444
provideTestRealtime(SF_TYPE_REGISTRY),
4545
{ provide: FileService, useMock: mockedFileService },

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-note-dialog/text-note-dialog.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { NoteDialogData, TextNoteDialogComponent, TextNoteType } from './text-no
1313

1414
describe('TextNoteDialogComponent', () => {
1515
configureTestingModule(() => ({
16-
imports: [getTestTranslocoModule(), TextNoteDialogComponent],
16+
imports: [getTestTranslocoModule(false), TextNoteDialogComponent],
1717
providers: [provideNoopAnimations()]
1818
}));
1919
let env: TestEnvironment;

src/SIL.XForge.Scripture/ClientApp/src/app/translate/biblical-terms/biblical-terms.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { SlicePipe } from '@angular/common';
1+
import { NgFor, SlicePipe } from '@angular/common';
22
import { Component, DestroyRef, ElementRef, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
33
import { FormsModule } from '@angular/forms';
44
import { MatIconButton } from '@angular/material/button';
@@ -195,6 +195,7 @@ class Row {
195195
templateUrl: './biblical-terms.component.html',
196196
styleUrls: ['./biblical-terms.component.scss'],
197197
imports: [
198+
NgFor,
198199
FormsModule,
199200
TranslocoModule,
200201
MatTooltip,

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('DraftGenerationComponent', () => {
7878
}
7979

8080
TestBed.configureTestingModule({
81-
imports: [, getTestTranslocoModule()],
81+
imports: [getTestTranslocoModule()],
8282
providers: [
8383
provideRouter([]),
8484
provideTestOnlineStatus(),

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-sources/draft-sources.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { NgTemplateOutlet } from '@angular/common';
12
import { Component, DestroyRef, EventEmitter } from '@angular/core';
23
import { MatButton } from '@angular/material/button';
34
import { MatCard, MatCardActions, MatCardContent, MatCardHeader, MatCardTitle } from '@angular/material/card';
@@ -41,6 +42,7 @@ import {
4142
import { LanguageCodesConfirmationComponent } from '../language-codes-confirmation/language-codes-confirmation.component';
4243
import { TrainingDataMultiSelectComponent } from '../training-data/training-data-multi-select.component';
4344
import { TrainingDataService } from '../training-data/training-data.service';
45+
4446
/** Status for a project, which may or may not be at SF. */
4547
export interface ProjectStatus {
4648
shortName: string;
@@ -53,6 +55,7 @@ export interface ProjectStatus {
5355
@Component({
5456
selector: 'app-draft-sources',
5557
imports: [
58+
NgTemplateOutlet,
5659
MatButton,
5760
MatIcon,
5861
MatRipple,

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/test-utils.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -60,25 +60,21 @@ export const configureTestingModule = (createModuleDef: () => TestModuleMetadata
6060
});
6161
};
6262

63-
// export const TestTranslocoModule = TranslocoTestingModule.forRoot({
64-
// langs: { en },
65-
// translocoConfig: {
66-
// availableLangs: ['en'],
67-
// reRenderOnLangChange: true,
68-
// fallbackLang: 'en',
69-
// defaultLang: 'en'
70-
// }
71-
// });
72-
73-
export function getTestTranslocoModule(): ModuleWithProviders<TranslocoTestingModule> {
63+
/**
64+
* Gets a Transloco testing module with 'en' translations loaded.
65+
* @param loadLangs Whether to preload the languages. Set to false if tests want to use the untranslated key.
66+
* Default is true.
67+
*/
68+
export function getTestTranslocoModule(loadLangs = true): ModuleWithProviders<TranslocoTestingModule> {
7469
return TranslocoTestingModule.forRoot({
7570
langs: { en },
7671
translocoConfig: {
7772
availableLangs: ['en'],
7873
reRenderOnLangChange: true,
7974
fallbackLang: 'en',
8075
defaultLang: 'en'
81-
}
76+
},
77+
preloadLangs: loadLangs
8278
});
8379
}
8480

0 commit comments

Comments
 (0)