SF-3444 Prevent error when rapidly clicking Lynx panel insights (#3290)

Author: siltomato

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-overlay.service.ts

@@ -88,11 +88,11 @@ export class LynxInsightOverlayService {
         }
       });
 
-    // When initially displayed, scroll editor if necessary to ensure overlay is displayed within editor bounds
-    setTimeout(() => this.ensureOverlayWithinEditorBounds(overlayRef.ref));
-
     this.openRef = overlayRef;
 
+    // When initially displayed, scroll editor if necessary to ensure overlay is displayed within editor bounds
+    setTimeout(() => this.ensureOverlayWithinEditorBounds());
+
     return overlayRef;
   }
 
@@ -174,8 +174,10 @@ export class LynxInsightOverlayService {
   /**
    * Ensures the overlay is fully within the editor bounds.
    */
-  private ensureOverlayWithinEditorBounds(overlayRef: OverlayRef): void {
-    if (this.scrollableContainer == null) {
+  private ensureOverlayWithinEditorBounds(): void {
+    const overlayRef: OverlayRef | undefined = this.openRef?.ref;
+
+    if (this.scrollableContainer == null || overlayRef?.overlayElement == null) {
       return;
     }