wip

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/src/app/shared/diagnostic-overlay/diagnostic-overlay.component.scss

@@ -83,7 +83,7 @@ h3 {
 
 .tab-content {
   overflow: auto;
-  padding: 8px;
+  padding-bottom: 1em;
 }
 
 .nav-wrapper {

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/models/realtime-doc.ts

@@ -4,6 +4,7 @@ import { Presence } from 'sharedb/lib/sharedb';
 import { RealtimeService } from 'xforge-common/realtime.service';
 import { PresenceData } from '../../app/shared/text/text.component';
 import { RealtimeDocAdapter } from '../realtime-remote-store';
+import { isNG0911Error } from '../util/rxjs-util';
 import { RealtimeOfflineData } from './realtime-offline-data';
 import { Snapshot } from './snapshot';
 
@@ -44,8 +45,10 @@ export class DocSubscription {
     readonly callerContext: string,
     destroyRef?: DestroyRef
   ) {
-    if (destroyRef != null) {
-      destroyRef.onDestroy(() => (this.isUnsubscribed = true));
+    try {
+      destroyRef?.onDestroy(() => (this.isUnsubscribed = true));
+    } catch (error) {
+      if (!isNG0911Error(error)) throw error;
     }
   }
 

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/util/rxjs-util.ts

@@ -13,6 +13,10 @@ export function filterNullish<T>(): OperatorFunction<T | undefined | null, T> {
   return filter((value): value is T => value != null);
 }
 
+export function isNG0911Error(error: unknown): boolean {
+  return hasStringProp(error, 'message') && error.message.includes('NG0911');
+}
+
 /**
  * Like `takeUntilDestroyed`, but catches and logs NG0911 errors (unless `options.logWarnings` is false).
  */
@@ -26,11 +30,10 @@ export function quietTakeUntilDestroyed<T>(
       try {
         return destroyRef.onDestroy(callback);
       } catch (error) {
-        const isNG0911 = hasStringProp(error, 'message') && error.message.includes('NG0911');
-        if (isNG0911 && options.logWarnings) {
+        if (isNG0911Error(error) && options.logWarnings) {
           console.warn('NG0911 error caught and ignored. Original stack: ', stack);
         }
-        if (!isNG0911) throw error;
+        if (!isNG0911Error(error)) throw error;
         callback();
         return () => {};
       }