Review comments

Author: josephmyers

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.service.spec.ts

@@ -225,6 +225,23 @@ describe('DraftGenerationService', () => {
       });
       tick();
     }));
+
+    it('should return undefined and show error when server returns 500', fakeAsync(() => {
+      // SUT
+      service.getLastPreTranslationBuild(projectId).subscribe(result => {
+        expect(result).toBeUndefined();
+        verify(mockNoticeService.showError(anything())).once();
+      });
+      tick();
+
+      // Setup the HTTP request
+      const req = httpTestingController.expectOne(
+        `${MACHINE_API_BASE_URL}translation/engines/project:${projectId}/actions/getLastPreTranslationBuild`
+      );
+      expect(req.request.method).toEqual('GET');
+      req.flush(null, { status: HttpStatusCode.InternalServerError, statusText: 'Server Error' });
+      tick();
+    }));
   });
 
   describe('getBuildHistory', () => {

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts

@@ -327,21 +327,20 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
         }),
         filter(([isOnline, _]) => {
           return isOnline && this.doesLatestCompletedHaveDraft;
+        }),
+        switchMap(() => this.refreshLastPreTranslationBuild()),
+        tap((build: BuildDto | undefined) => {
+          this._latestPreTranslationBuild = build;
         })
       )
-      .subscribe(() => this.refreshLastPreTranslationBuild());
+      .subscribe();
   }
 
-  private refreshLastPreTranslationBuild(): void {
+  private refreshLastPreTranslationBuild(): Observable<BuildDto | undefined> {
     if (this.projectId == null) {
-      return;
+      return of<BuildDto | undefined>(undefined);
     }
-    this.draftGenerationService
-      .getLastPreTranslationBuild(this.projectId)
-      .pipe(quietTakeUntilDestroyed(this.destroyRef), take(1))
-      .subscribe((build: BuildDto | undefined) => {
-        this._latestPreTranslationBuild = build;
-      });
+    return this.draftGenerationService.getLastPreTranslationBuild(this.projectId).pipe(take(1));
   }
 
   navigateToFormatting(): void {

test/SIL.XForge.Scripture.Tests/Services/MachineApiServiceTests.cs

@@ -2087,7 +2087,7 @@ public async Task GetLastPreTranslationBuildAsync_LatestByDateFinished_Success()
             Message = MachineApiService.BuildStateCompleted,
             Progress = 100,
             Revision = 11,
-            State = JobState.Completed,
+            State = JobState.Canceled,
             DateFinished = now.AddMinutes(-5),
         };
         env.TranslationEnginesClient.GetAllBuildsAsync(TranslationEngine01, CancellationToken.None)